ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-18 20:47:57 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Exclude kotlin.jvm.internal from api scanning (#4478)

Browse Source
This commit is contained in:
Dimos Raptis 2019-01-07 15:02:32 +00:00 committed by GitHub
parent b13e92cb24
commit e39b2fbe9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.ci/check-api-changes.sh
View File

@ -44,10 +44,12 @@ $newAbstracts
EOF EOF
` `
#Get a list of any methods that expose classes in .internal. namespaces, and any classes which extend/implement # Get a list of any methods that expose internal classes, which includes:
#an internal class # - classes in .internal. namespaces (excluding the kotlin.jvm.internal namespace)
# - classes which extend/implement an internal class (see above)
# - classes in the net.corda.node. namespace
#TODO: check that only classes in a whitelist are part of the API rather than look for specific invalid cases going forward #TODO: check that only classes in a whitelist are part of the API rather than look for specific invalid cases going forward
newInternalExposures=$(echo "$userDiffContents" | grep "^+" | grep "\.internal\." ) newInternalExposures=$(echo "$userDiffContents" | grep "^+" | grep "(?<!kotlin\.jvm)\.internal\." )
newNodeExposures=$(echo "$userDiffContents" | grep "^+" | grep "net\.corda\.node\.") newNodeExposures=$(echo "$userDiffContents" | grep "^+" | grep "net\.corda\.node\.")
internalCount=`grep -v "^$" <<EOF | wc -l internalCount=`grep -v "^$" <<EOF | wc -l