From d9f0a161e42a6a60b6131546684a761596cd39f1 Mon Sep 17 00:00:00 2001 From: Jose Coll Date: Tue, 1 Nov 2016 12:05:48 +0000 Subject: [PATCH] Addressed comments in PR review. --- core/src/main/kotlin/com/r3corda/core/node/PluginServiceHub.kt | 2 ++ .../r3corda/node/services/persistence/DataVendingService.kt | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/main/kotlin/com/r3corda/core/node/PluginServiceHub.kt b/core/src/main/kotlin/com/r3corda/core/node/PluginServiceHub.kt index 7f6d6c2894..6814ab1c25 100644 --- a/core/src/main/kotlin/com/r3corda/core/node/PluginServiceHub.kt +++ b/core/src/main/kotlin/com/r3corda/core/node/PluginServiceHub.kt @@ -19,6 +19,8 @@ interface PluginServiceHub : ServiceHub { * form: registerProtocolInitiator(InitiatorProtocol::class, ::InitiatedProtocol) * @param protocolFactory The protocol factory generating the initiated protocol. */ + + // TODO: remove dependency on Kotlin relfection (Kotlin KClass -> Java Class). fun registerProtocolInitiator(markerClass: KClass<*>, protocolFactory: (Party) -> ProtocolLogic<*>) /** diff --git a/node/src/main/kotlin/com/r3corda/node/services/persistence/DataVendingService.kt b/node/src/main/kotlin/com/r3corda/node/services/persistence/DataVendingService.kt index 149ce3d21f..66a5c13639 100644 --- a/node/src/main/kotlin/com/r3corda/node/services/persistence/DataVendingService.kt +++ b/node/src/main/kotlin/com/r3corda/node/services/persistence/DataVendingService.kt @@ -32,9 +32,6 @@ object DataVending { * Additionally, because nodes do not store invalid transactions, requesting such a transaction will always yield null. */ @ThreadSafe - // TODO: I don't like that this needs ServiceHubInternal, but passing in a state machine breaks MockServices because -// the state machine isn't set when this is constructed. [NodeSchedulerService] has the same problem, and both -// should be fixed at the same time. class Service(services: PluginServiceHub) : SingletonSerializeAsToken() { companion object {