From d685c2154b64d9f84bf3bfc9366f79674e1217a3 Mon Sep 17 00:00:00 2001
From: Shams Asari <shams.asari@r3.com>
Date: Tue, 11 Jun 2019 11:51:30 +0100
Subject: [PATCH] ENT-3489: Removing unnecessary @CordaSerializable annotation
 from exceptions (#5209)

---
 .idea/compiler.xml                                            | 4 ++--
 .../corda/core/contracts/TransactionVerificationException.kt  | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/.idea/compiler.xml b/.idea/compiler.xml
index b98e8af1f4..f4c21d4188 100644
--- a/.idea/compiler.xml
+++ b/.idea/compiler.xml
@@ -193,8 +193,8 @@
       <module name="network-visualiser_test" target="1.8" />
       <module name="node-api_main" target="1.8" />
       <module name="node-api_test" target="1.8" />
-      <module name="node-capsule_main" target="1.6" />
-      <module name="node-capsule_test" target="1.6" />
+      <module name="node-capsule_main" target="1.8" />
+      <module name="node-capsule_test" target="1.8" />
       <module name="node-driver_integrationTest" target="1.8" />
       <module name="node-driver_main" target="1.8" />
       <module name="node-driver_test" target="1.8" />
diff --git a/core/src/main/kotlin/net/corda/core/contracts/TransactionVerificationException.kt b/core/src/main/kotlin/net/corda/core/contracts/TransactionVerificationException.kt
index c00696018d..84429f19bf 100644
--- a/core/src/main/kotlin/net/corda/core/contracts/TransactionVerificationException.kt
+++ b/core/src/main/kotlin/net/corda/core/contracts/TransactionVerificationException.kt
@@ -266,7 +266,6 @@ abstract class TransactionVerificationException(val txId: SecureHash, message: S
     /**
      * Thrown when multiple attachments provide the same file when building the AttachmentsClassloader for a transaction.
      */
-    @CordaSerializable
     @KeepForDJVM
     class OverlappingAttachmentsException(txId: SecureHash, val path: String) : TransactionVerificationException(txId, "Multiple attachments define a file at $path.", null)
 
@@ -275,20 +274,17 @@ abstract class TransactionVerificationException(val txId: SecureHash, message: S
      * the [txId] will always be [SecureHash.zeroHash] because package ownership is an error with a particular attachment,
      * and because attachment classloaders are reused this is independent of any particular transaction.
      */
-    @CordaSerializable
     class PackageOwnershipException(txId: SecureHash, @Suppress("unused") val attachmentHash: AttachmentId, @Suppress("unused") val invalidClassName: String, val packageName: String) : TransactionVerificationException(txId,
             """The attachment JAR: $attachmentHash containing the class: $invalidClassName is not signed by the owner of package $packageName specified in the network parameters.
            Please check the source of this attachment and if it is malicious contact your zone operator to report this incident.
            For details see: https://docs.corda.net/network-map.html#network-parameters""".trimIndent(), null)
 
-    @CordaSerializable
     class InvalidAttachmentException(txId: SecureHash, @Suppress("unused") val attachmentHash: AttachmentId) : TransactionVerificationException(txId,
             "The attachment $attachmentHash is not a valid ZIP or JAR file.".trimIndent(), null)
 
     // TODO: Make this descend from TransactionVerificationException so that untrusted attachments cause flows to be hospitalized.
     /** Thrown during classloading upon encountering an untrusted attachment (eg. not in the [TRUSTED_UPLOADERS] list) */
     @KeepForDJVM
-    @CordaSerializable
     class UntrustedAttachmentsException(val txId: SecureHash, val ids: List<SecureHash>) :
             CordaException("Attempting to load untrusted transaction attachments: $ids. " +
                     "At this time these are not loadable because the DJVM sandbox has not yet been integrated. " +