ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-20 13:33:12 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

TM-43 updating code style docs to reflect the addition of Detekt (#5521)

Browse Source
This commit is contained in:
Razvan Codreanu 2019-09-30 11:55:24 +01:00 committed by josecoll
parent 7dd6ecf96e
commit ccdd5a20dd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/source/codestyle.rst
View File

@ -5,8 +5,9 @@ This document explains the coding style used in the Corda repository. You will b
recommendations when submitting patches for review. Please take the time to read them and internalise them, to save recommendations when submitting patches for review. Please take the time to read them and internalise them, to save
time during code review. time during code review.
What follows are *recommendations* and not *rules*. They are in places intentionally vague, so use your good judgement What follows are mostly *recommendations* and not *rules*. They are in places intentionally vague, so use your good judgement
when interpreting them. when interpreting them. The rules that are currently being enforced via the Detekt PR gateway can be found `here
<https://github.com/corda/corda/blob/release/os/4.3/detekt-config.yml>`_.
1. General style 1. General style
################ ################
@ -35,10 +36,9 @@ that doesn't mean it's always better. In particular:
1.1 Line Length and Spacing 1.1 Line Length and Spacing
--------------------------- ---------------------------
We aim for line widths of no more than 120 characters. That is wide enough to avoid lots of pointless wrapping but We aim for line widths of no more than 140 characters. That is wide enough to avoid lots of pointless wrapping but
narrow enough that with a widescreen monitor and a 12 point fixed width font (like Menlo) you can fit two files narrow enough that with a widescreen monitor and a 12 point fixed width font (like Menlo) you can fit two files
next to each other. This is not a rigidly enforced rule and if wrapping a line would be excessively awkward, let it next to each other. This is a rule that we enforce.
overflow. Overflow of a few characters here and there isn't a big deal: the goal is general convenience.
Where the number of parameters in a function, class, etc. causes an overflow past the end of the first line, they should Where the number of parameters in a function, class, etc. causes an overflow past the end of the first line, they should
be structured one parameter per line. be structured one parameter per line.