ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-24 07:06:44 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ENT-12108 ReceiveFinalityFlow returns a transaction that is not signed by the notary (#7804)

Browse Source
This commit is contained in:
Rick Parker 2024-08-15 07:06:58 +01:00 committed by GitHub
parent d888dea3c2
commit cc44c77ed4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core-tests/src/test/kotlin/net/corda/coretests/flows/FinalityFlowTests.kt
View File

@ -518,7 +518,8 @@ class FinalityFlowTests : WithFinality {
@Suspendable @Suspendable
override fun call() { override fun call() {
val handleNotaryError = otherSide.receive<Boolean>().unwrap { it } val handleNotaryError = otherSide.receive<Boolean>().unwrap { it }
subFlow(ReceiveFinalityFlow(otherSide, handlePropagatedNotaryError = handleNotaryError)) val stx = subFlow(ReceiveFinalityFlow(otherSide, handlePropagatedNotaryError = handleNotaryError))
stx.verify(serviceHub)
} }
} }

1
core/src/main/kotlin/net/corda/core/flows/ReceiveTransactionFlow.kt
View File

@ -127,6 +127,7 @@ open class ReceiveTransactionFlow constructor(private val otherSideSession: Flow
(serviceHub as ServiceHubCoreInternal).finalizeTransactionWithExtraSignatures(stx, notarySignatures, statesToRecord) (serviceHub as ServiceHubCoreInternal).finalizeTransactionWithExtraSignatures(stx, notarySignatures, statesToRecord)
logger.info("Peer finalised transaction with notary signature.") logger.info("Peer finalised transaction with notary signature.")
} }
return stx + notarySignatures
} catch (e: NotaryException) { } catch (e: NotaryException) {
logger.info("Peer received notary error.") logger.info("Peer received notary error.")
val overrideHandlePropagatedNotaryError = handlePropagatedNotaryError val overrideHandlePropagatedNotaryError = handlePropagatedNotaryError