mirror of
https://github.com/corda/corda.git
synced 2024-12-24 07:06:44 +00:00
Minor improvements to github templates.
This commit is contained in:
parent
3ae56a00b2
commit
cb5ba4cc3b
2
.github/ISSUE_TEMPLATE.md
vendored
2
.github/ISSUE_TEMPLATE.md
vendored
@ -3,6 +3,6 @@ Thank you for choosing to report an issue with Corda.
|
|||||||
When reporting an issue please make sure it contains;
|
When reporting an issue please make sure it contains;
|
||||||
|
|
||||||
* A clear description of the issue
|
* A clear description of the issue
|
||||||
* Any logs or stack traces that you can provide (use a site like [pastebin](https://pastebin.com)for larger logs)
|
* Any logs or stack traces that you can provide (use a site like https://pastebin.com for larger logs)
|
||||||
* Steps to reproduce the issue
|
* Steps to reproduce the issue
|
||||||
* The version/tag/release or commit hash it occured on
|
* The version/tag/release or commit hash it occured on
|
20
.github/PULL_REQUEST_TEMPLATE.md
vendored
20
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -1,17 +1,21 @@
|
|||||||
Thank you for choosing to contribute to Corda.
|
Thank you for choosing to contribute to Corda.
|
||||||
|
|
||||||
## PR Process
|
PR Process
|
||||||
|
----------
|
||||||
|
|
||||||
Your PR must be approved by one or more reviewers and all tests must be passed on [TeamCity CI](https://ci.corda.r3cev.com)
|
Your PR must be approved by one or more reviewers and all tests must be passed on TeamCity (https://ci.corda.r3cev.com)
|
||||||
in order to be merged.
|
in order to be merged.
|
||||||
|
|
||||||
Once you have submitted a PR you are responsible for keeping it up to date until the time it is merged.
|
Once you have submitted a PR you are responsible for keeping it up to date until the time it is merged.
|
||||||
|
|
||||||
## PR Checklist
|
PR Checklist
|
||||||
|
------------
|
||||||
|
|
||||||
1. Ensure any new code is tested as described [here](https://docs.corda.net/testing.html)
|
1. Ensure any new code is tested as described in https://docs.corda.net/testing.html
|
||||||
2. Ensure you have done any relevant automated testing and manual testing
|
2. Ensure you have done any relevant automated testing and manual testing
|
||||||
3. Add your changes to `docs/source/changelog.rst`
|
3. Add your changes to docs/source/changelog.rst
|
||||||
4. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html)
|
4. Update any documentation in docs/source relating to your changes and learn how to build them in https://docs.corda.net/building-the-docs.html
|
||||||
5. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now
|
5. If you are contributing for the first time please read the agreement in CONTRIBUTING.md now and add to this
|
||||||
and add to this Pull Request that you have read, and agreed to, the agreement.
|
Pull Request that you have read, and agreed to, the agreement.
|
||||||
|
|
||||||
|
Please remove this message when you have read it.
|
||||||
|
Loading…
Reference in New Issue
Block a user