ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-01-18 18:56:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

CORDA-3194 Update TODOs with jira tickets

Browse Source
This commit is contained in:
LankyDan 2019-10-22 11:25:31 +01:00
parent 8f2923c7a3
commit c5124689ca
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
node/src/integration-test/kotlin/net/corda/node/services/statemachine/StatemachineErrorHandlingTest.kt
View File

@ -403,7 +403,7 @@ class StatemachineErrorHandlingTest : IntegrationTest() {
* if an error transition moves into another error transition. The flow still recovers from this state. 5 exceptions were thrown to verify * if an error transition moves into another error transition. The flow still recovers from this state. 5 exceptions were thrown to verify
* that 3 retries are attempted before recovering. * that 3 retries are attempted before recovering.
* *
* TODO Fix this scenario - it is currently hanging after putting the flow in for observation * CORDA-3352 - it is currently hanging after putting the flow in for observation
*/ */
@Test @Test
@Ignore @Ignore
@ -874,7 +874,7 @@ class StatemachineErrorHandlingTest : IntegrationTest() {
* The flow is discharged and replayed from the hospital once. After failing during the replay, the flow is forced into overnight * The flow is discharged and replayed from the hospital once. After failing during the replay, the flow is forced into overnight
* observation. It is not ran again after this point * observation. It is not ran again after this point
* *
* TODO Fix this scenario - it is currently hanging after putting the flow in for observation * CORDA-3352 - it is currently hanging after putting the flow in for observation
* *
*/ */
@Test @Test

2
node/src/main/kotlin/net/corda/node/services/statemachine/StateTransitionExceptions.kt
View File

@ -3,7 +3,7 @@ package net.corda.node.services.statemachine
import net.corda.core.CordaException import net.corda.core.CordaException
import net.corda.core.serialization.ConstructorForDeserialization import net.corda.core.serialization.ConstructorForDeserialization
// TODO These exceptions should not be propagated up to rpc as they suppress the real exceptions // CORDA-3353 - These exceptions should not be propagated up to rpc as they suppress the real exceptions
class StateTransitionException( class StateTransitionException(
val transitionAction: Action?, val transitionAction: Action?,

2
node/src/main/kotlin/net/corda/node/services/statemachine/TransitionExecutorImpl.kt
View File

@ -48,6 +48,8 @@ class TransitionExecutorImpl(
// Instead we just keep around the old error state and wait for a new schedule, perhaps // Instead we just keep around the old error state and wait for a new schedule, perhaps
// triggered from a flow hospital // triggered from a flow hospital
log.warn("Error while executing $action during transition to errored state, aborting transition", exception) log.warn("Error while executing $action during transition to errored state, aborting transition", exception)
// CORDA-3354 - Go to the hospital with the new error that has occurred
// while already in a error state (as this error could be for a different reason)
return Pair(FlowContinuation.Abort, previousState.copy(isFlowResumed = false)) return Pair(FlowContinuation.Abort, previousState.copy(isFlowResumed = false))
} else { } else {
// Otherwise error the state manually keeping the old flow state and schedule a DoRemainingWork // Otherwise error the state manually keeping the old flow state and schedule a DoRemainingWork