ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-01-06 05:04:20 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix parameter ordering in windows.cpp's MySystem::visit

Browse Source 
It's amazing to me that ebp and esp have been swapped for over three
years without anybody noticing.  It was dumb luck that the Trace test
(which is designed to catch just such a thing) happened to fail when I
ran the whole suite, and further investigation revealed that it was
failing maybe five percent of the times it was run.  Now we know why.
This commit is contained in:
Joel Dice 2013-03-15 16:08:55 -06:00
parent 54b560b149
commit bad3a7979c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vm/system/windows.cpp
View File

@ -775,12 +775,12 @@ class MySystem: public System {
if (rv) {
# ifdef ARCH_x86_32
visitor->visit(reinterpret_cast<void*>(context.Eip),
reinterpret_cast<void*>(context.Ebp),
reinterpret_cast<void*>(context.Esp));
reinterpret_cast<void*>(context.Esp),
reinterpret_cast<void*>(context.Ebp));
# elif defined ARCH_x86_64
visitor->visit(reinterpret_cast<void*>(context.Rip),
reinterpret_cast<void*>(context.Rbp),
reinterpret_cast<void*>(context.Rsp));
reinterpret_cast<void*>(context.Rsp),
reinterpret_cast<void*>(context.Rbp));
# endif
success = true;
}