diff --git a/client/rpc/src/integration-test/kotlin/net/corda/client/rpc/RPCStabilityTests.kt b/client/rpc/src/integration-test/kotlin/net/corda/client/rpc/RPCStabilityTests.kt index 251fa11ff5..b325c0bc8f 100644 --- a/client/rpc/src/integration-test/kotlin/net/corda/client/rpc/RPCStabilityTests.kt +++ b/client/rpc/src/integration-test/kotlin/net/corda/client/rpc/RPCStabilityTests.kt @@ -46,7 +46,7 @@ class RPCStabilityTests { values.poll() } val first = values.peek() - if (values.size == 5 && values.all { it == first } ) { + if (values.size == 5 && values.all { it == first }) { first } else { null @@ -63,11 +63,11 @@ class RPCStabilityTests { startRpcClient(server.get().hostAndPort).get() } } - for (i in 1 .. 5) { + repeat(5) { startAndStop() } val numberOfThreadsBefore = waitUntilNumberOfThreadsStable(executor) - for (i in 1 .. 5) { + repeat(5) { startAndStop() } val numberOfThreadsAfter = waitUntilNumberOfThreadsStable(executor) @@ -87,11 +87,11 @@ class RPCStabilityTests { ErrorOr.catch { startRpcClient(server.get().hostAndPort, configuration = RPCClientConfiguration.default.copy(minimumServerProtocolVersion = 1)).get() } } } - for (i in 1 .. 5) { + repeat(5) { startAndStop() } val numberOfThreadsBefore = waitUntilNumberOfThreadsStable(executor) - for (i in 1 .. 5) { + repeat(5) { startAndStop() } val numberOfThreadsAfter = waitUntilNumberOfThreadsStable(executor) diff --git a/client/rpc/src/main/kotlin/net/corda/client/rpc/internal/RPCClientProxyHandler.kt b/client/rpc/src/main/kotlin/net/corda/client/rpc/internal/RPCClientProxyHandler.kt index 5a4e5c307e..3d5232481c 100644 --- a/client/rpc/src/main/kotlin/net/corda/client/rpc/internal/RPCClientProxyHandler.kt +++ b/client/rpc/src/main/kotlin/net/corda/client/rpc/internal/RPCClientProxyHandler.kt @@ -281,7 +281,7 @@ class RPCClientProxyHandler( // leak borrowed executors. val observationExecutors = observationExecutorPool.close() observationExecutors.forEach { it.shutdownNow() } - lifeCycle.transition(State.FINISHED) + lifeCycle.justTransition(State.FINISHED) } /** diff --git a/core/src/main/kotlin/net/corda/core/utilities/LifeCycle.kt b/core/src/main/kotlin/net/corda/core/utilities/LifeCycle.kt index ba97af78e8..bc73e9f51a 100644 --- a/core/src/main/kotlin/net/corda/core/utilities/LifeCycle.kt +++ b/core/src/main/kotlin/net/corda/core/utilities/LifeCycle.kt @@ -37,7 +37,7 @@ class LifeCycle>(initial: S) { } /** Transition the state to [to] without performing a current state check. */ - fun transition(to: S) { + fun justTransition(to: S) { lock.writeLock().withLock { state = to } diff --git a/node/src/main/kotlin/net/corda/node/services/messaging/RPCServer.kt b/node/src/main/kotlin/net/corda/node/services/messaging/RPCServer.kt index 9ebfec125c..693bbdf1e8 100644 --- a/node/src/main/kotlin/net/corda/node/services/messaging/RPCServer.kt +++ b/node/src/main/kotlin/net/corda/node/services/messaging/RPCServer.kt @@ -184,7 +184,7 @@ class RPCServer( it.session.close() it.sessionFactory.close() } - lifeCycle.transition(State.FINISHED) + lifeCycle.justTransition(State.FINISHED) } private fun bindingRemovalArtemisMessageHandler(artemisMessage: ClientMessage) {