mirror of
https://github.com/corda/corda.git
synced 2025-01-21 03:55:00 +00:00
add a TODO comment about class comparison
This commit is contained in:
parent
831c529a98
commit
a81879129a
@ -394,6 +394,13 @@ public class Classes {
|
||||
}
|
||||
|
||||
private static boolean match(VMClass a, VMClass b) {
|
||||
// TODO: in theory we should be able to just do an == comparison
|
||||
// here instead of recursively comparing array element types.
|
||||
// However, the VM currently can create multiple array classes for
|
||||
// the same element type. We should fix that so that there's only
|
||||
// ever one of each per classloader, eliminating the need for a
|
||||
// recursive comparison. See also the native implementation of
|
||||
// isAssignableFrom.
|
||||
if (a.arrayDimensions > 0) {
|
||||
return match(a.arrayElementClass, b.arrayElementClass);
|
||||
} else {
|
||||
|
Loading…
Reference in New Issue
Block a user