ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-02-01 16:58:27 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

add a TODO comment about class comparison

Browse Source
This commit is contained in:
Joel Dice 2014-09-03 16:24:15 -06:00
parent 831c529a98
commit a81879129a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
classpath/avian/Classes.java
View File

@ -394,6 +394,13 @@ public class Classes {
} }
private static boolean match(VMClass a, VMClass b) { private static boolean match(VMClass a, VMClass b) {
// TODO: in theory we should be able to just do an == comparison
// here instead of recursively comparing array element types.
// However, the VM currently can create multiple array classes for
// the same element type. We should fix that so that there's only
// ever one of each per classloader, eliminating the need for a
// recursive comparison. See also the native implementation of
// isAssignableFrom.
if (a.arrayDimensions > 0) { if (a.arrayDimensions > 0) {
return match(a.arrayElementClass, b.arrayElementClass); return match(a.arrayElementClass, b.arrayElementClass);
} else { } else {