ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-20 21:43:14 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Add debugging information in case of missing signatures

Browse Source
This commit is contained in:
Ross Nicoll 2016-08-08 17:43:25 +01:00
parent 17ae349f4d
commit a2dff5488f
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/src/main/kotlin/com/r3corda/core/contracts/Transactions.kt
View File

@ -12,6 +12,7 @@ import com.r3corda.core.serialization.serialize
import com.r3corda.core.utilities.Emoji import com.r3corda.core.utilities.Emoji
import java.security.PublicKey import java.security.PublicKey
import java.security.SignatureException import java.security.SignatureException
import java.util.*
/** /**
* Views of a transaction as it progresses through the pipeline, from bytes loaded from disk/network to the object * Views of a transaction as it progresses through the pipeline, from bytes loaded from disk/network to the object
@ -115,8 +116,20 @@ data class SignedTransaction(val txBits: SerializedBytes<WireTransaction>,
// Now examine the contents and ensure the sigs we have line up with the advertised list of signers. // Now examine the contents and ensure the sigs we have line up with the advertised list of signers.
val missing = getMissingSignatures() val missing = getMissingSignatures()
if (missing.isNotEmpty() && throwIfSignaturesAreMissing) if (missing.isNotEmpty() && throwIfSignaturesAreMissing) {
throw SignatureException("Missing signatures on transaction ${id.prefixChars()} for: ${missing.map { it.toStringShort() }}") // Take a best guess at where the signatures are required from, for debugging
// TODO: We need a much better way of structuring this data
val missingElements = ArrayList<String>()
this.tx.commands.forEach { command ->
if (command.signers.any { signer -> missing.contains(signer) })
missingElements.add(command.toString())
}
this.tx.notary?.owningKey.apply {
if (missing.contains(this))
missingElements.add("notary")
}
throw SignatureException("Missing signatures for ${missingElements} on transaction ${id.prefixChars()} for ${missing.map { it.toStringShort() }}")
}
return missing return missing
} }