mirror of
https://github.com/corda/corda.git
synced 2025-02-06 11:09:18 +00:00
Address review comments
This commit is contained in:
parent
49a0fd8fdd
commit
a030a45019
@ -36,6 +36,8 @@ class FinalityProtocol(val transaction: SignedTransaction,
|
|||||||
|
|
||||||
@Suspendable
|
@Suspendable
|
||||||
override fun call() {
|
override fun call() {
|
||||||
|
// TODO: Resolve the tx here: it's probably already been done, but re-resolution is a no-op and it'll make the API more forgiving.
|
||||||
|
|
||||||
progressTracker.currentStep = NOTARISING
|
progressTracker.currentStep = NOTARISING
|
||||||
// Notarise the transaction if needed
|
// Notarise the transaction if needed
|
||||||
val notarisedTransaction = if (needsNotarySignature(transaction)) {
|
val notarisedTransaction = if (needsNotarySignature(transaction)) {
|
||||||
|
@ -85,7 +85,6 @@ object NotaryChangeProtocol: AbstractStateReplacementProtocol<Party>() {
|
|||||||
val blacklist = listOf("Evil Notary")
|
val blacklist = listOf("Evil Notary")
|
||||||
require(!blacklist.contains(newNotary.name)) { "The proposed new notary $newNotary is not trusted by the party" }
|
require(!blacklist.contains(newNotary.name)) { "The proposed new notary $newNotary is not trusted by the party" }
|
||||||
|
|
||||||
|
|
||||||
proposal
|
proposal
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user