ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-01-16 09:50:11 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Revert @Ignore for ErrorMessageTests (causing AMQP serialization failure)

Browse Source
This commit is contained in:
josecoll 2018-01-15 15:45:42 +00:00
parent 120500646c
commit 97423bbf94
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
node-api/src/test/java/net/corda/nodeapi/internal/serialization/amqp/ErrorMessageTests.java
View File

@ -2,10 +2,12 @@ package net.corda.nodeapi.internal.serialization.amqp;
import net.corda.nodeapi.internal.serialization.AllWhitelist; import net.corda.nodeapi.internal.serialization.AllWhitelist;
import org.assertj.core.api.Assertions; import org.assertj.core.api.Assertions;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import java.io.NotSerializableException; import java.io.NotSerializableException;
@Ignore("Current behaviour allows for the serialization of objects with private members, this will be disallowed at some point in the future")
public class ErrorMessageTests { public class ErrorMessageTests {
private String errMsg(String property, String testname) { private String errMsg(String property, String testname) {
return "Property '" return "Property '"

9
node-api/src/test/kotlin/net/corda/nodeapi/internal/serialization/amqp/ErrorMessagesTests.kt
View File

@ -1,6 +1,7 @@
package net.corda.nodeapi.internal.serialization.amqp package net.corda.nodeapi.internal.serialization.amqp
import org.assertj.core.api.Assertions import org.assertj.core.api.Assertions
import org.junit.Ignore
import org.junit.Test import org.junit.Test
import java.io.NotSerializableException import java.io.NotSerializableException
@ -12,6 +13,8 @@ class ErrorMessagesTests {
private fun errMsg(property:String, testname: String) = private fun errMsg(property:String, testname: String) =
"Property '$property' or its getter is non public, this renders class 'class $testname\$C' unserializable -> class $testname\$C" "Property '$property' or its getter is non public, this renders class 'class $testname\$C' unserializable -> class $testname\$C"
// Java allows this to be set at the class level yet Kotlin doesn't for some reason
@Ignore("Current behaviour allows for the serialization of objects with private members, this will be disallowed at some point in the future")
@Test @Test
fun privateProperty() { fun privateProperty() {
data class C(private val a: Int) data class C(private val a: Int)
@ -25,6 +28,8 @@ class ErrorMessagesTests {
}.isInstanceOf(NotSerializableException::class.java).hasMessage(errMsg("a", testname)) }.isInstanceOf(NotSerializableException::class.java).hasMessage(errMsg("a", testname))
} }
// Java allows this to be set at the class level yet Kotlin doesn't for some reason
@Ignore("Current behaviour allows for the serialization of objects with private members, this will be disallowed at some point in the future")
@Test @Test
fun privateProperty2() { fun privateProperty2() {
data class C(val a: Int, private val b: Int) data class C(val a: Int, private val b: Int)
@ -38,6 +43,8 @@ class ErrorMessagesTests {
}.isInstanceOf(NotSerializableException::class.java).hasMessage(errMsg("b", testname)) }.isInstanceOf(NotSerializableException::class.java).hasMessage(errMsg("b", testname))
} }
// Java allows this to be set at the class level yet Kotlin doesn't for some reason
@Ignore("Current behaviour allows for the serialization of objects with private members, this will be disallowed at some point in the future")
@Test @Test
fun privateProperty3() { fun privateProperty3() {
// despite b being private, the getter we've added is public and thus allows for the serialisation // despite b being private, the getter we've added is public and thus allows for the serialisation
@ -54,6 +61,8 @@ class ErrorMessagesTests {
val c = DeserializationInput(sf).deserialize(bytes) val c = DeserializationInput(sf).deserialize(bytes)
} }
// Java allows this to be set at the class level yet Kotlin doesn't for some reason
@Ignore("Current behaviour allows for the serialization of objects with private members, this will be disallowed at some point in the future")
@Test @Test
fun protectedProperty() { fun protectedProperty() {
data class C(protected val a: Int) data class C(protected val a: Int)