Fix jackson serialization of transaction types. By default it attempts to serialize

any property (any getter), which causes issues on the SignedTransaction, since it
attempts to resolve both a regular and a notary change transaction from the serialized bytes.

client/jackson/src/main/kotlin/net/corda/jackson/JacksonSupport.kt

@@ -1,5 +1,7 @@
 package net.corda.jackson
 
+import com.fasterxml.jackson.annotation.JsonIgnore
+import com.fasterxml.jackson.annotation.JsonProperty
 import com.fasterxml.jackson.core.*
 import com.fasterxml.jackson.databind.*
 import com.fasterxml.jackson.databind.deser.std.NumberDeserializers
@@ -9,6 +11,8 @@ import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
 import com.fasterxml.jackson.module.kotlin.KotlinModule
 import net.corda.contracts.BusinessCalendar
 import net.corda.core.contracts.Amount
+import net.corda.core.contracts.ContractState
+import net.corda.core.contracts.StateRef
 import net.corda.core.crypto.*
 import net.corda.core.crypto.composite.CompositeKey
 import net.corda.core.identity.AbstractParty
@@ -17,9 +21,14 @@ import net.corda.core.identity.Party
 import net.corda.core.messaging.CordaRPCOps
 import net.corda.core.node.NodeInfo
 import net.corda.core.node.services.IdentityService
-import net.corda.core.utilities.OpaqueBytes
+import net.corda.core.serialization.SerializedBytes
 import net.corda.core.serialization.deserialize
 import net.corda.core.serialization.serialize
+import net.corda.core.transactions.CoreTransaction
+import net.corda.core.transactions.NotaryChangeWireTransaction
+import net.corda.core.transactions.SignedTransaction
+import net.corda.core.transactions.WireTransaction
+import net.corda.core.utilities.OpaqueBytes
 import net.i2p.crypto.eddsa.EdDSAPublicKey
 import org.bouncycastle.asn1.x500.X500Name
 import java.math.BigDecimal
@@ -109,6 +118,10 @@ object JacksonSupport {
             // For X.500 distinguished names
             addDeserializer(X500Name::class.java, X500NameDeserializer)
             addSerializer(X500Name::class.java, X500NameSerializer)
+
+            // Mixins for transaction types to prevent some properties from being serialized
+            setMixInAnnotation(SignedTransaction::class.java, SignedTransactionMixin::class.java)
+            setMixInAnnotation(WireTransaction::class.java, WireTransactionMixin::class.java)
         }
     }
 
@@ -278,7 +291,7 @@ object JacksonSupport {
     object CalendarSerializer : JsonSerializer<BusinessCalendar>() {
         override fun serialize(obj: BusinessCalendar, generator: JsonGenerator, context: SerializerProvider) {
             val calendarName = BusinessCalendar.calendars.find { BusinessCalendar.getInstance(it) == obj }
-            if(calendarName != null) {
+            if (calendarName != null) {
                 generator.writeString(calendarName)
             } else {
                 generator.writeObject(BusinessCalendarWrapper(obj.holidayDates))
@@ -371,5 +384,24 @@ object JacksonSupport {
             gen.writeBinary(value.bytes)
         }
     }
+
+    abstract class SignedTransactionMixin {
+        @JsonIgnore abstract fun getTxBits(): SerializedBytes<CoreTransaction>
+        @JsonProperty("signatures") protected abstract fun getSigs(): List<TransactionSignature>
+        @JsonProperty protected abstract fun getTransaction(): CoreTransaction
+        @JsonIgnore abstract fun getTx(): WireTransaction
+        @JsonIgnore abstract fun getNotaryChangeTx(): NotaryChangeWireTransaction
+        @JsonIgnore abstract fun getInputs(): List<StateRef>
+        @JsonIgnore abstract fun getNotary(): Party?
+        @JsonIgnore abstract fun getId(): SecureHash
+        @JsonIgnore abstract fun getRequiredSigningKeys(): Set<PublicKey>
+    }
+
+    abstract class WireTransactionMixin {
+        @JsonIgnore abstract fun getMerkleTree(): MerkleTree
+        @JsonIgnore abstract fun getAvailableComponents(): List<Any>
+        @JsonIgnore abstract fun getAvailableComponentHashes(): List<SecureHash>
+        @JsonIgnore abstract fun getOutputStates(): List<ContractState>
+    }
 }
 

client/jackson/src/test/kotlin/net/corda/jackson/JacksonSupportTest.kt

@@ -6,8 +6,16 @@ import com.pholser.junit.quickcheck.Property
 import com.pholser.junit.quickcheck.runner.JUnitQuickcheck
 import net.corda.core.contracts.Amount
 import net.corda.core.contracts.USD
+import net.corda.core.crypto.Crypto
+import net.corda.core.crypto.SignatureMetadata
+import net.corda.core.crypto.TransactionSignature
 import net.corda.core.testing.PublicKeyGenerator
+import net.corda.core.transactions.SignedTransaction
+import net.corda.testing.ALICE_PUBKEY
+import net.corda.testing.DUMMY_NOTARY
+import net.corda.testing.MINI_CORP
 import net.corda.testing.TestDependencyInjectionBase
+import net.corda.testing.contracts.DummyContract
 import net.i2p.crypto.eddsa.EdDSAPublicKey
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -51,4 +59,24 @@ class JacksonSupportTest : TestDependencyInjectionBase() {
         val writer = mapper.writer().without(SerializationFeature.INDENT_OUTPUT)
         assertEquals("""{"notional":"25000000.00 USD"}""", writer.writeValueAsString(Dummy(Amount.parseCurrency("$25000000"))))
     }
+
+    @Test
+    fun writeTransaction() {
+        fun makeDummyTx(): SignedTransaction {
+            val wtx = DummyContract.generateInitial(1, DUMMY_NOTARY, MINI_CORP.ref(1)).toWireTransaction()
+            val signatures = TransactionSignature(
+                    ByteArray(1),
+                    ALICE_PUBKEY,
+                    SignatureMetadata(
+                            1,
+                            Crypto.findSignatureScheme(ALICE_PUBKEY).schemeNumberID
+                    )
+            )
+            return SignedTransaction(wtx, listOf(signatures))
+        }
+
+        val writer = mapper.writer()
+        // We don't particularly care about the serialized format, just need to make sure it completes successfully.
+        writer.writeValueAsString(makeDummyTx())
+    }
 }