Remove IssuerFlow

* Remove IssuerFlow as it is dangerous and its presence in the finance module risks accidental use in non-test code. As written it will issue arbitary amounts of currency on request from any node on the network, with no validation barring that the currency type is valid.
* Unify interface to CashIssueFlow to match the previous IssuerFlow

docs/source/example-code/src/integration-test/kotlin/net/corda/docs/IntegrationTestingTutorial.kt

@@ -67,9 +67,11 @@ class IntegrationTestingTutorial {
                 thread {
                     futures.push(aliceProxy.startFlow(::CashIssueFlow,
                             i.DOLLARS,
-                            issueRef,
                             bob.nodeInfo.legalIdentity,
-                            notary.nodeInfo.notaryIdentity
+                            alice.nodeInfo.legalIdentity,
+                            issueRef,
+                            notary.nodeInfo.notaryIdentity,
+                            true
                     ).returnValue)
                 }
             }.forEach(Thread::join) // Ensure the stack of futures is populated.

docs/source/example-code/src/main/kotlin/net/corda/docs/ClientRpcTutorial.kt

@@ -128,7 +128,7 @@ fun generateTransactions(proxy: CordaRPCOps) {
             proxy.startFlow(::CashPaymentFlow, Amount(quantity, USD), me)
         } else {
             val quantity = Math.abs(random.nextLong() % 1000)
-            proxy.startFlow(::CashIssueFlow, Amount(quantity, USD), issueRef, me, notary)
+            proxy.startFlow(::CashIssueFlow, Amount(quantity, USD), me, me, issueRef, notary, true)
             ownedQuantity += quantity
         }
     }

docs/source/example-code/src/main/kotlin/net/corda/docs/CustomVaultQuery.kt

@@ -132,8 +132,9 @@ object TopupIssuerFlow {
             val notaryParty = serviceHub.networkMapCache.notaryNodes[0].notaryIdentity
             // invoke Cash subflow to issue Asset
             progressTracker.currentStep = ISSUING
+            val issuer = serviceHub.myInfo.legalIdentity
             val issueRecipient = serviceHub.myInfo.legalIdentity
-            val issueCashFlow = CashIssueFlow(amount, issuerPartyRef, issueRecipient, notaryParty, anonymous = false)
+            val issueCashFlow = CashIssueFlow(amount, issueRecipient, issuer, issuerPartyRef, notaryParty, anonymous = false)
             val issueTx = subFlow(issueCashFlow)
             // NOTE: issueCashFlow performs a Broadcast (which stores a local copy of the txn to the ledger)
             // short-circuit when issuing to self

docs/source/example-code/src/test/kotlin/net/corda/docs/CustomVaultQueryTest.kt

@@ -65,10 +65,11 @@ class CustomVaultQueryTest {
     private fun issueCashForCurrency(amountToIssue: Amount<Currency>) {
         // Use NodeA as issuer and create some dollars
         val flowHandle1 = nodeA.services.startFlow(CashIssueFlow(amountToIssue,
-                OpaqueBytes.of(0x01),
                 nodeA.info.legalIdentity,
+                nodeA.info.legalIdentity,
+                OpaqueBytes.of(0x01),
                 notaryNode.info.notaryIdentity,
-                false))
+                anonymous = false))
         // Wait for the flow to stop and print
         flowHandle1.resultFuture.getOrThrow()
     }

docs/source/example-code/src/test/kotlin/net/corda/docs/FxTransactionBuildTutorialTest.kt

@@ -45,8 +45,9 @@ class FxTransactionBuildTutorialTest {
     fun `Run ForeignExchangeFlow to completion`() {
         // Use NodeA as issuer and create some dollars
         val flowHandle1 = nodeA.services.startFlow(CashIssueFlow(DOLLARS(1000),
-                OpaqueBytes.of(0x01),
                 nodeA.info.legalIdentity,
+                nodeA.info.legalIdentity,
+                OpaqueBytes.of(0x01),
                 notaryNode.info.notaryIdentity,
                 false))
         // Wait for the flow to stop and print
@@ -55,8 +56,9 @@ class FxTransactionBuildTutorialTest {
 
         // Using NodeB as Issuer create some pounds.
         val flowHandle2 = nodeB.services.startFlow(CashIssueFlow(POUNDS(1000),
-                OpaqueBytes.of(0x01),
                 nodeB.info.legalIdentity,
+                nodeB.info.legalIdentity,
+                OpaqueBytes.of(0x01),
                 notaryNode.info.notaryIdentity,
                 false))
         // Wait for flow to come to an end and print