CORDA-2535 - Fixes to IRS demo (#4995)

* CORDA-2535 Move classes from test src to main

For some reason a load of classes were in the test src rather than the
main src even though they were needed during runtime. These have been
moved back into main so they are compiled for use in the demo app.

* CORDA-2535 Fix missing trade id irs-demo home page

Change `deal.ref` to `deal.common.tradeID`

* CORDA-2535 Highlight in irs-demo that `node` module should not be depended on

The demo relies on `node` unless some larger refactoring is made. This
is being kept as it is, but to discourage developers from doing the
same in their CorDapps, a comment has been added to `build.gradle`
explaining why it is there and that developers should not do the same.

samples/irs-demo/cordapp/workflows-irs/build.gradle

@@ -14,6 +14,10 @@ dependencies {
 
     // Corda integration dependencies
     cordaCompile project(':core')
+    
+    // only included to control the `DemoClock` as part of the demo application
+    // normally `:node` should not be depended on in any CorDapps
+    cordaCompile project(':node')
 
     // Cordapp dependencies
     // Specify your cordapp's dependencies below, including dependent cordapps

samples/irs-demo/web/src/main/resources/static/view/deal.html

@@ -20,7 +20,7 @@
                 </tr>
                 <tr class="center aligned">
                     <td>Trade ID</td>
-                    <td>{{deal.ref}}</td>
+                    <td>{{deal.common.tradeID}}</td>
                 </tr>
                 <tr class="center aligned">
                     <td>Valuation Date</td>

samples/irs-demo/web/src/main/resources/static/view/home.html

@@ -45,8 +45,8 @@
             </tr>
             </thead>
             <tbody>
-            <tr class="center aligned" ng-repeat="deal in deals" id="deal-{{deal.ref}}">
-                <td><a href="#/deal/{{deal.ref}}">{{deal.ref}}</a></td>
+            <tr class="center aligned" ng-repeat="deal in deals" id="deal-{{deal.common.tradeID}}">
+                <td><a href="#/deal/{{deal.common.tradeID}}">{{deal.common.tradeID}}</a></td>
                 <td class="single line">{{renderX500Name(deal.fixedLeg.fixedRatePayer)}}</td>
                 <td class="single line">{{deal.fixedLeg.notional}}</td>
                 <td class="single line">{{renderX500Name(deal.floatingLeg.floatingRatePayer)}}</td>