CORDA-1790 - Roll back flow transaction on exception (#3597) (#3616)

* CORDA-1790 Roll back flow transaction on exception

* CORDA-1790 Roll back flow transaction on exception

* CORDA-1790 Roll back flow transaction on exception

node/src/main/kotlin/net/corda/node/services/statemachine/FlowStateMachineImpl.kt

@@ -147,6 +147,19 @@ class FlowStateMachineImpl<R>(override val id: StateMachineRunId,
         }
     }
 
+    internal fun rollbackTransaction() {
+        val transaction = contextTransaction
+        try {
+            logger.trace { "Rolling back transaction $transaction on ${Strand.currentStrand()}." }
+            transaction.rollback()
+        } catch (e: SQLException) {
+            logger.error("Transaction rollback failed: ${e.message}", e)
+            System.exit(1)
+        } finally {
+            transaction.close()
+        }
+    }
+
     @Suspendable
     override fun initiateFlow(otherParty: Party, sessionFlow: FlowLogic<*>): FlowSession {
         val sessionKey = Pair(sessionFlow, otherParty)

node/src/main/kotlin/net/corda/node/services/statemachine/StateMachineManagerImpl.kt

@@ -452,10 +452,14 @@ class StateMachineManagerImpl(
                 }
                 endAllFiberSessions(fiber, result, propagated)
             } finally {
+                if (result.isSuccess) {
                     fiber.commitTransaction()
-                decrementLiveFibers()
                     totalFinishedFlows.inc()
                     unfinishedFibers.countDown()
+                } else {
+                    fiber.rollbackTransaction()
+                }
+                decrementLiveFibers()
             }
         }
         mutex.locked {

node/src/test/kotlin/net/corda/node/services/statemachine/FlowFrameworkTests.kt

@@ -375,7 +375,7 @@ class FlowFrameworkTests {
                 .withMessage("Nothing useful")
                 .withStackTraceContaining(ReceiveFlow::class.java.name)  // Make sure the stack trace is that of the receiving flow
         bobNode.database.transaction {
-            assertThat(bobNode.checkpointStorage.checkpoints()).isEmpty()
+            assertThat(bobNode.checkpointStorage.checkpoints()).isNotEmpty()
         }
 
         assertThat(receivingFiber.isTerminated).isTrue()