ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-18 20:47:57 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Extract method to fix detekt ComplexMethod failure

Browse Source
This commit is contained in:
Joseph Zuniga-Daly 2020-08-19 17:18:39 +01:00
parent e79f4ab8e2
commit 6a776a267b
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
serialization/src/main/kotlin/net/corda/serialization/internal/amqp/ObjectBuilder.kt
View File

@ -124,12 +124,7 @@ interface ObjectBuilder {
}.toMutableMap() }.toMutableMap()
if (includeAllConstructorParameters) { if (includeAllConstructorParameters) {
// Add constructor parameters not in the list of properties addMissingConstructorParameters(constructorIndices, constructor)
// so we can use them in object evolution
for ((parameterIndex, parameter) in constructor.parameters.withIndex()) {
// Only use the parameters not already matched to properties
constructorIndices.putIfAbsent(parameter.name, parameterIndex)
}
} }
val propertySlots = constructorIndices.keys.mapIndexed { slot, name -> name to slot }.toMap() val propertySlots = constructorIndices.keys.mapIndexed { slot, name -> name to slot }.toMap()
@ -139,6 +134,15 @@ interface ObjectBuilder {
} }
} }
private fun addMissingConstructorParameters(constructorIndices: MutableMap<String, Int>, constructor: LocalConstructorInformation) {
// Add constructor parameters not in the list of properties
// so we can use them in object evolution
for ((parameterIndex, parameter) in constructor.parameters.withIndex()) {
// Only use the parameters not already matched to properties
constructorIndices.putIfAbsent(parameter.name, parameterIndex)
}
}
private fun makeSetterBasedProvider( private fun makeSetterBasedProvider(
properties: Map<String, LocalPropertyInformation>, properties: Map<String, LocalPropertyInformation>,
typeIdentifier: TypeIdentifier, typeIdentifier: TypeIdentifier,