ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-06-03 16:10:58 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Increase JDBCHashMap default bucket size. With the current implementa… (#58)

Browse Source 
Increase JDBCHashMap default bucket size. With the current implementation of the Vault, once the number of stored transactions (or UTXO) goes over the max bucket size we end up reloading each transaction from the db and deserializing it, which causes severe performance degradation.
This commit is contained in:
Andrius Dagys 2016-12-15 15:45:51 +00:00 committed by GitHub
parent 66477a0955
commit 673b0393b4
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
node/src/main/kotlin/net/corda/node/utilities/JDBCHashMap.kt
View File

@ -18,6 +18,14 @@ import kotlin.system.measureTimeMillis
* access patterns and performance requirements. * access patterns and performance requirements.
*/ */
/**
* The default maximum size of the LRU cache.
*
* TODO: make this value configurable
* TODO: tune this value, as it's currently mostly a guess
*/
val DEFAULT_MAX_BUCKETS = 4096
/** /**
* A convenient JDBC table backed hash map with iteration order based on insertion order. * A convenient JDBC table backed hash map with iteration order based on insertion order.
* See [AbstractJDBCHashMap] for further implementation details. * See [AbstractJDBCHashMap] for further implementation details.
@ -28,7 +36,7 @@ import kotlin.system.measureTimeMillis
*/ */
class JDBCHashMap<K : Any, V : Any>(tableName: String, class JDBCHashMap<K : Any, V : Any>(tableName: String,
loadOnInit: Boolean = false, loadOnInit: Boolean = false,
maxBuckets: Int = 256) maxBuckets: Int = DEFAULT_MAX_BUCKETS)
: AbstractJDBCHashMap<K, V, JDBCHashMap.BlobMapTable>(BlobMapTable(tableName), loadOnInit, maxBuckets) { : AbstractJDBCHashMap<K, V, JDBCHashMap.BlobMapTable>(BlobMapTable(tableName), loadOnInit, maxBuckets) {
class BlobMapTable(tableName: String) : JDBCHashedTable(tableName) { class BlobMapTable(tableName: String) : JDBCHashedTable(tableName) {
@ -78,7 +86,7 @@ fun <T : Any> deserializeFromBlob(blob: Blob): T = bytesFromBlob<T>(blob).deseri
*/ */
class JDBCHashSet<K : Any>(tableName: String, class JDBCHashSet<K : Any>(tableName: String,
loadOnInit: Boolean = false, loadOnInit: Boolean = false,
maxBuckets: Int = 256) maxBuckets: Int = DEFAULT_MAX_BUCKETS)
: AbstractJDBCHashSet<K, JDBCHashSet.BlobSetTable>(BlobSetTable(tableName), loadOnInit, maxBuckets) { : AbstractJDBCHashSet<K, JDBCHashSet.BlobSetTable>(BlobSetTable(tableName), loadOnInit, maxBuckets) {
class BlobSetTable(tableName: String) : JDBCHashedTable(tableName) { class BlobSetTable(tableName: String) : JDBCHashedTable(tableName) {
@ -100,7 +108,7 @@ class JDBCHashSet<K : Any>(tableName: String,
*/ */
abstract class AbstractJDBCHashSet<K : Any, out T : JDBCHashedTable>(protected val table: T, abstract class AbstractJDBCHashSet<K : Any, out T : JDBCHashedTable>(protected val table: T,
loadOnInit: Boolean = false, loadOnInit: Boolean = false,
maxBuckets: Int = 256) : MutableSet<K>, AbstractSet<K>() { maxBuckets: Int = DEFAULT_MAX_BUCKETS) : MutableSet<K>, AbstractSet<K>() {
protected val innerMap = object : AbstractJDBCHashMap<K, Unit, T>(table, loadOnInit, maxBuckets) { protected val innerMap = object : AbstractJDBCHashMap<K, Unit, T>(table, loadOnInit, maxBuckets) {
override fun keyFromRow(row: ResultRow): K = this@AbstractJDBCHashSet.elementFromRow(row) override fun keyFromRow(row: ResultRow): K = this@AbstractJDBCHashSet.elementFromRow(row)
@ -194,7 +202,7 @@ abstract class AbstractJDBCHashSet<K : Any, out T : JDBCHashedTable>(protected v
*/ */
abstract class AbstractJDBCHashMap<K : Any, V : Any, out T : JDBCHashedTable>(val table: T, abstract class AbstractJDBCHashMap<K : Any, V : Any, out T : JDBCHashedTable>(val table: T,
val loadOnInit: Boolean = false, val loadOnInit: Boolean = false,
val maxBuckets: Int = 256) : MutableMap<K, V>, AbstractMap<K, V>() { val maxBuckets: Int = DEFAULT_MAX_BUCKETS) : MutableMap<K, V>, AbstractMap<K, V>() {
companion object { companion object {
protected val log = loggerFor<AbstractJDBCHashMap<*, *, *>>() protected val log = loggerFor<AbstractJDBCHashMap<*, *, *>>()