From 5f446aea7e1e22eb46baa758438823eab2550d2b Mon Sep 17 00:00:00 2001
From: Kyriakos Tharrouniatis <kyriakos.tharrouniatis@r3.com>
Date: Tue, 11 Feb 2020 14:11:35 +0000
Subject: [PATCH] Add explanatory comment about why we changed Observer.tee to
 use unsafe subscribe

---
 core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt b/core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt
index fcfd9a5986..3d170290b5 100644
--- a/core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt
+++ b/core/src/main/kotlin/net/corda/core/internal/InternalUtils.kt
@@ -192,6 +192,9 @@ fun <T> Observable<T>.bufferUntilSubscribed(): Observable<T> {
 @DeleteForDJVM
 fun <T> Observer<T>.tee(vararg teeTo: Observer<T>): Observer<T> {
     val subject = PublishSubject.create<T>()
+    // use unsafe subscribe, so that the teed subscribers will not get wrapped with SafeSubscribers,
+    // therefore a potential raw exception (non Rx) coming from a child -unsafe subscribed- observer
+    // will not unsubscribe all of the subscribers under the PublishSubject.
     subject.unsafeSubscribe(Subscribers.from(this))
     teeTo.forEach { subject.unsafeSubscribe(Subscribers.from(it)) }
     return subject