From 544d09ea18c0d32a09152437f72a4ddbcbf8de9f Mon Sep 17 00:00:00 2001 From: Stefano Franz Date: Tue, 29 Jan 2019 15:13:27 +0000 Subject: [PATCH] update docs to reflect the removal of the bundled finance app --- docs/source/app-upgrade-notes.rst | 6 ++---- docs/source/changelog.rst | 6 +++--- docs/source/cordapp-build-systems.rst | 1 - docs/source/generating-a-node.rst | 14 +++++++------- docs/source/hello-world-running.rst | 6 +++--- docs/source/testnet-explorer-corda.rst | 2 +- 6 files changed, 16 insertions(+), 19 deletions(-) diff --git a/docs/source/app-upgrade-notes.rst b/docs/source/app-upgrade-notes.rst index ae91d5009b..8f82e64aea 100644 --- a/docs/source/app-upgrade-notes.rst +++ b/docs/source/app-upgrade-notes.rst @@ -108,9 +108,7 @@ CorDapp specific versionId identifiers if this follows the convention of always starting from 1. If you use the finance demo app, you should adjust your dependencies so you depend on the finance-contracts -and finance-workflows artifacts from your own contract and workflow JAR respectively. Although a single -finance jar still exists in Corda 4 for backwards compatibility, it should not be installed or used for -updated apps. This way, only the code that needs to be on the ledger actually will be. +and finance-workflows artifacts from your own contract and workflow JAR respectively. Step 3. Security: Upgrade your use of FinalityFlow -------------------------------------------------- @@ -326,7 +324,7 @@ There are two improvements to how Java package protection is handled in Corda 4: 1. Package sealing 2. Package namespace ownership -**Sealing.** App isolation has been improved. Version 4 of the finance CorDapp (*corda-finance.jar*) is now built as a set of sealed and +**Sealing.** App isolation has been improved. Version 4 of the finance CorDapps (*corda-finance-contracts.jar*, *corda-finance-workflows.jar*) is now built as a set of sealed and signed JAR files. This means classes in your own CorDapps cannot be placed under the following package namespace: ``net.corda.finance`` In the unlikely event that you were injecting code into ``net.corda.finance.*`` package namespaces from your own apps, you will need to move them diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 1d1b9da994..c67c7eb863 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -315,10 +315,10 @@ Version 4.0 * CorDapps built by ``corda-gradle-plugins`` are now signed and sealed JAR files. Signing can be configured or disabled, and it defaults to using the Corda development certificate. -* Finance CorDapp is now build as a sealed and signed JAR file. - Custom classes can no longer be placed in the packages defined in Finance Cordapp or access it's non-public members. +* Finance CorDapps are now built as a sealed and signed JAR file. + Custom classes can no longer be placed in the packages defined in either finance Cordapp or access it's non-public members. -* Finance CorDapp was split into two separate apps: ``corda-finance-contracts`` and ``corda-finance-workflows``. +* Finance CorDapp was split into two separate apps: ``corda-finance-contracts`` and ``corda-finance-workflows``. There is no longer a single cordapp which provides both. * All sample CorDapps were split into separate apps: workflows and contracts to reflect new convention. It is recommended to structure your CorDapps this way, see :doc:`app-upgrade-notes` on upgrading your CorDapp. diff --git a/docs/source/cordapp-build-systems.rst b/docs/source/cordapp-build-systems.rst index 300da04670..d32c194b1d 100644 --- a/docs/source/cordapp-build-systems.rst +++ b/docs/source/cordapp-build-systems.rst @@ -106,7 +106,6 @@ Here is an overview of the various Corda dependencies: * ``corda-core-deterministic`` - Used by the Corda node for deterministic contracts. Not likely to be used externally * ``corda-djvm`` - Used by the Corda node for deterministic contracts. Not likely to be used externally * ``corda-finance-contracts``, ``corda-finance-workflows`` and deprecated ``corda-finance``. Corda finance CorDapp, use contracts and flows parts respectively. - ``corda-finance`` is left for backward compatibility purposes and should be replaced by former two where needed. Only include as a ``cordaCompile`` dependency if using as a dependent Cordapp or if you need access to the Corda finance types. Use as a ``cordapp`` dependency if using as a CorDapp dependency (see below) * ``corda-jackson`` - Corda Jackson support. Use if you plan to serialise Corda objects to and/or from JSON diff --git a/docs/source/generating-a-node.rst b/docs/source/generating-a-node.rst index 496c031afb..bfa19e0266 100644 --- a/docs/source/generating-a-node.rst +++ b/docs/source/generating-a-node.rst @@ -46,7 +46,7 @@ in the `Kotlin CorDapp Template -corda/corda-finance--corda.jar + wget https://ci-artifactory.corda.r3cev.com/artifactory/corda-releases/net/corda/corda-finance-contracts-/-corda/corda-finance--corda.jar This is required to run some flows to check your connections, and to issue/transfer cash to counterparties. Copy it to the Corda installation location: