ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-20 05:28:21 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Minor: make NodeAttachmentStorage open streams lazily to avoid resource leaks and to make checking for attachment existence fast.

Browse Source
This commit is contained in:
Mike Hearn 2016-02-26 16:49:40 +01:00
parent a6835c4c04
commit 48b2e561b7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/kotlin/core/node/NodeAttachmentStorage.kt
View File

@ -71,13 +71,15 @@ class NodeAttachmentStorage(val storePath: Path) : AttachmentStorage {
override fun openAttachment(id: SecureHash): Attachment? { override fun openAttachment(id: SecureHash): Attachment? {
val path = storePath.resolve(id.toString()) val path = storePath.resolve(id.toString())
if (!Files.exists(path)) return null if (!Files.exists(path)) return null
return object : Attachment {
override fun open(): InputStream {
var stream = Files.newInputStream(path) var stream = Files.newInputStream(path)
// This is just an optional safety check. If it slows things down too much it can be disabled. // This is just an optional safety check. If it slows things down too much it can be disabled.
if (id is SecureHash.SHA256 && checkAttachmentsOnLoad) if (id is SecureHash.SHA256 && checkAttachmentsOnLoad)
stream = HashCheckingStream(id, path, stream) stream = HashCheckingStream(id, path, stream)
log.debug("Opening attachment $id") log.debug("Opening attachment $id")
return object : Attachment { return stream
override fun open(): InputStream = stream }
override val id: SecureHash = id override val id: SecureHash = id
override fun equals(other: Any?) = other is Attachment && other.id == id override fun equals(other: Any?) = other is Attachment && other.id == id
override fun hashCode(): Int = id.hashCode() override fun hashCode(): Int = id.hashCode()