ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-06-21 16:49:45 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

ENT-1670: update kdocs and unit test for better user experience (#2875)

Browse Source 
* ENT-1670: update kdocs and unit test for better user experience regarding
RPC connection loss

* RPCStabilityTests: move doOnError logic to onError handler
This commit is contained in:
bpaunescu
2018-03-26 14:27:35 +01:00
committed by GitHub
parent c3031b182b
commit 47c7be62c0
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
client/rpc/src/integration-test/kotlin/net/corda/client/rpc/RPCStabilityTests.kt
View File

@ -305,16 +305,21 @@ class RPCStabilityTests {
var terminateHandlerCalled = false var terminateHandlerCalled = false
var errorHandlerCalled = false var errorHandlerCalled = false
var exceptionMessage: String? = null
val subscription = client.subscribe() val subscription = client.subscribe()
.doOnTerminate{ terminateHandlerCalled = true } .doOnTerminate{ terminateHandlerCalled = true }
.doOnError { errorHandlerCalled = true } .subscribe({}, {
.subscribe() errorHandlerCalled = true
//log exception
exceptionMessage = it.message
})
serverFollower.shutdown() serverFollower.shutdown()
Thread.sleep(100) Thread.sleep(100)
assertTrue(terminateHandlerCalled) assertTrue(terminateHandlerCalled)
assertTrue(errorHandlerCalled) assertTrue(errorHandlerCalled)
assertEquals("Connection failure detected.", exceptionMessage)
assertTrue(subscription.isUnsubscribed) assertTrue(subscription.isUnsubscribed)
clientFollower.shutdown() // Driver would do this after the new server, causing hang. clientFollower.shutdown() // Driver would do this after the new server, causing hang.

4
client/rpc/src/main/kotlin/net/corda/client/rpc/CordaRPCClient.kt
View File

@ -89,6 +89,10 @@ interface CordaRPCClientConfiguration {
* with an error, the observable is closed and you can't then re-subscribe again: you'll have to re-request a fresh * with an error, the observable is closed and you can't then re-subscribe again: you'll have to re-request a fresh
* observable with another RPC. * observable with another RPC.
* *
* In case of loss of connection to the server, the client will try to reconnect using the settings provided via
* [CordaRPCClientConfiguration]. While attempting failover, current and future RPC calls will throw
* [RPCException] and previously returned observables will call onError().
*
* @param hostAndPort The network address to connect to. * @param hostAndPort The network address to connect to.
* @param configuration An optional configuration used to tweak client behaviour. * @param configuration An optional configuration used to tweak client behaviour.
* @param sslConfiguration An optional [SSLConfiguration] used to enable secure communication with the server. * @param sslConfiguration An optional [SSLConfiguration] used to enable secure communication with the server.