From 38ab78c07e728a09f1d33eb301866602f93999ab Mon Sep 17 00:00:00 2001 From: Katelyn Baker Date: Thu, 8 Mar 2018 20:44:53 +0000 Subject: [PATCH] CORDA-1192 - Quieten message when reflecting on kotlin builtin (#2769) --- .../serialization/amqp/PropertySerializers.kt | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/node-api/src/main/kotlin/net/corda/nodeapi/internal/serialization/amqp/PropertySerializers.kt b/node-api/src/main/kotlin/net/corda/nodeapi/internal/serialization/amqp/PropertySerializers.kt index 9029dd171b..5c8a8ef376 100644 --- a/node-api/src/main/kotlin/net/corda/nodeapi/internal/serialization/amqp/PropertySerializers.kt +++ b/node-api/src/main/kotlin/net/corda/nodeapi/internal/serialization/amqp/PropertySerializers.kt @@ -34,7 +34,13 @@ class PublicPropertyReader(private val readMethod: Method?) : PropertyReader() { // is: https://youtrack.jetbrains.com/issue/KT-13077 // TODO: Revisit this when Kotlin issue is fixed. - loggerFor().error("Unexpected internal Kotlin error", e) + // So this used to report as an error, but given we serialise exceptions all the time it + // provides for very scary log files so move this to trace level + loggerFor().let { logger -> + logger.trace("Using kotlin introspection on internal type ${this.declaringClass}") + logger.trace("Unexpected internal Kotlin error", e) + } + return true } } @@ -70,7 +76,13 @@ class PrivatePropertyReader(val field: Field, parentType: Type) : PropertyReader // This might happen for some types, e.g. kotlin.Throwable? - the root cause of the issue // is: https://youtrack.jetbrains.com/issue/KT-13077 // TODO: Revisit this when Kotlin issue is fixed. - loggerFor().error("Unexpected internal Kotlin error", e) + + // So this used to report as an error, but given we serialise exceptions all the time it + // provides for very scary log files so move this to trace level + loggerFor().let { logger -> + logger.trace("Using kotlin introspection on internal type $field") + logger.trace("Unexpected internal Kotlin error", e) + } true } }