From 37c89d7cf60421b4f3f4687d51f1ceab701dc38d Mon Sep 17 00:00:00 2001 From: Mike Hearn Date: Tue, 21 Jun 2016 18:04:34 +0200 Subject: [PATCH] Minor: add a TODO that the trader protocol should be recording the transaction itself instead of letting the caller do it. --- src/main/kotlin/com/r3corda/demos/TraderDemo.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/com/r3corda/demos/TraderDemo.kt b/src/main/kotlin/com/r3corda/demos/TraderDemo.kt index dbac9df7e2..d58f1659e7 100644 --- a/src/main/kotlin/com/r3corda/demos/TraderDemo.kt +++ b/src/main/kotlin/com/r3corda/demos/TraderDemo.kt @@ -16,6 +16,9 @@ import com.r3corda.core.protocols.ProtocolLogic import com.r3corda.core.random63BitValue import com.r3corda.core.seconds import com.r3corda.core.serialization.deserialize +import com.r3corda.core.utilities.BriefLogFormatter +import com.r3corda.core.utilities.Emoji +import com.r3corda.core.utilities.ProgressTracker import com.r3corda.node.internal.Node import com.r3corda.node.internal.testing.WalletFiller import com.r3corda.node.services.config.NodeConfigurationFromConfig @@ -23,9 +26,6 @@ import com.r3corda.node.services.messaging.ArtemisMessagingService import com.r3corda.node.services.network.NetworkMapService import com.r3corda.node.services.persistence.NodeAttachmentService import com.r3corda.node.services.transactions.SimpleNotaryService -import com.r3corda.core.utilities.BriefLogFormatter -import com.r3corda.core.utilities.Emoji -import com.r3corda.core.utilities.ProgressTracker import com.r3corda.protocols.NotaryProtocol import com.r3corda.protocols.TwoPartyTradeProtocol import com.typesafe.config.ConfigFactory @@ -250,6 +250,7 @@ class TraderDemoProtocolBuyer(private val attachmentsPath: Path, // This invokes the trading protocol and out pops our finished transaction. val tradeTX: SignedTransaction = subProtocol(buyer) + // TODO: This should be moved into the protocol itself. serviceHub.recordTransactions(listOf(tradeTX)) logger.info("Purchase complete - we are a happy customer! Final transaction is: " +