ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-04-12 21:53:17 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

CORDA-2837 Prevent node running SwapIdentitiesFlow from initiating session with itself (#5457)

Browse Source
This commit is contained in:
willhr3 2019-09-10 16:25:33 +01:00 committed by Roger Willis
parent aad2e82d07
commit 33055702a8
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
confidential-identities/src/main/kotlin/net/corda/confidential/SwapIdentitiesFlow.kt
View File

@ -90,10 +90,12 @@ private constructor(private val otherSideSession: FlowSession?,
@Suspendable
override fun call(): LinkedHashMap<Party, AnonymousParty> {
val session = otherSideSession ?: run {
val session = if (otherParty != null && otherParty != otherSideSession?.counterparty) {
logger.warnOnce("The current usage of SwapIdentitiesFlow is unsafe. Please consider upgrading your CorDapp to use " +
"SwapIdentitiesFlow with FlowSessions. (${CordappResolver.currentCordapp?.info})")
initiateFlow(otherParty!!)
initiateFlow(otherParty)
} else {
otherSideSession!!
}
progressTracker.currentStep = GENERATING_IDENTITY
val ourAnonymousIdentity = serviceHub.keyManagementService.freshKeyAndCert(ourIdentityAndCert, false)