ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-01-01 02:36:44 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

initialize MyThread::dynamicTable on thread creation

Browse Source 
Previously, I was lazily initializing this field in addDynamic, but
that only worked if a thread compiles an invokedynamic expression
prior to the first time it executes one, which is not always the case.

This is a bit tricky to write a simple test case for, since it
involves multiple threads, but I've tested it with a big, lambda-heavy
app and it fixes an otherwise consistent crash there.
This commit is contained in:
Joel Dice 2016-12-18 19:07:56 -07:00
parent bfc71e3a1e
commit 2c05d1515e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compile.cpp
View File

@ -1311,10 +1311,6 @@ Allocator* allocator(MyThread* t);
unsigned addDynamic(MyThread* t, GcInvocation* invocation)
{
if (t->dynamicTable == nullptr) {
t->dynamicTable = dynamicTable(t);
}
ACQUIRE(t, t->m->classLock);
int index = invocation->index();
@ -8828,6 +8824,7 @@ class MyProcessor : public Processor {
t->heapImage = heapImage;
t->codeImage = codeImage;
t->thunkTable = thunkTable;
t->dynamicTable = local::dynamicTable(t);
#if TARGET_BYTES_PER_WORD == BYTES_PER_WORD