ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-18 20:47:57 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #7818 from corda/cc/dev/os/4.9/dsl_orgunit

Browse Source 
ENT-12033 - Recognise OU in DSL node X500 name
This commit is contained in:
Adel El-Beik 2024-09-25 14:17:59 +01:00 committed by GitHub
commit 071c6da518
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 40 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
testing/node-driver/src/integration-test/kotlin/net/corda/testing/driver/DriverTests.kt
View File

@ -140,16 +140,42 @@ class DriverTests {
}
}
/**
* The uniqueness of nodes by the DSL is checked using the node organisation name and, if specified,
* the organisation unit name.
* All other X500 components are ignored in this regard.
*/
@Test(timeout=300_000)
fun `driver rejects multiple nodes with the same organisation name`() {
driver(DriverParameters(startNodesInProcess = true, notarySpecs = emptyList())) {
newNode(CordaX500Name(commonName = "Notary", organisation = "R3CEV", locality = "New York", country = "US"))().getOrThrow()
assertThatIllegalArgumentException().isThrownBy {
newNode(CordaX500Name(commonName = "Regulator", organisation = "R3CEV", locality = "New York", country = "US"))().getOrThrow()
newNode(CordaX500Name(commonName = "Regulator", organisation = "R3CEV", locality = "Newcastle", country = "GB"))().getOrThrow()
}
}
}
@Test(timeout=300_000)
fun `driver allows multiple nodes with the same organisation name but different organisation unit name`() {
driver(DriverParameters(startNodesInProcess = true, notarySpecs = emptyList())) {
newNode(CordaX500Name(commonName = "Notary", organisation = "R3CEV", organisationUnit = "Eric", locality = "New York", country = "US", state = null))().getOrThrow()
assertThatCode {
newNode(CordaX500Name(commonName = "Regulator", organisation = "R3CEV", organisationUnit = "Ernie", locality = "Newcastle", country = "GB", state = null))().getOrThrow()
}.doesNotThrowAnyException()
}
}
@Test(timeout=300_000)
fun `driver rejects multiple nodes with the same organisation name and organisation unit name`() {
driver(DriverParameters(startNodesInProcess = true, notarySpecs = emptyList())) {
newNode(CordaX500Name(commonName = "Notary", organisation = "R3CEV", organisationUnit = "Eric", locality = "New York", country = "US", state = null))().getOrThrow()
assertThatIllegalArgumentException().isThrownBy {
newNode(CordaX500Name(commonName = "Regulator", organisation = "R3CEV", organisationUnit = "Eric", locality = "Newcastle", country = "GB", state = null))().getOrThrow()
}
}
}
/** **** **/
@Test(timeout=300_000)
fun `driver allows reusing names of nodes that have been stopped`() {
driver(DriverParameters(startNodesInProcess = true, notarySpecs = emptyList())) {

17
testing/node-driver/src/main/kotlin/net/corda/testing/node/internal/DriverDSLImpl.kt
View File

@ -666,7 +666,11 @@ class DriverDSLImpl(
}
override fun baseDirectory(nodeName: CordaX500Name): Path {
val nodeDirectoryName = nodeName.organisation.filter { !it.isWhitespace() }
val nodeDirectoryName = if (nodeName.organisationUnit != null) {
"${nodeName.organisation}-${nodeName.organisationUnit}"
} else {
nodeName.organisation
}.filter { !it.isWhitespace() }
return driverDirectory / nodeDirectoryName
}
@ -1169,11 +1173,16 @@ private class NetworkVisibilityController {
fun register(name: CordaX500Name): VisibilityHandle {
val handle = VisibilityHandle()
val handleName = if (name.organisationUnit != null) {
"${name.organisation}-${name.organisationUnit}"
} else {
name.organisation
}
nodeVisibilityHandles.locked {
require(name.organisation !in keys) {
"Node with organisation name ${name.organisation} is already started or starting"
require(handleName !in keys) {
"Node with the organisation name (+ unit name) \"$handleName\" is already started or starting"
}
put(name.organisation, handle)
put(handleName, handle)
}
return handle
}