mirror of
https://github.com/balena-os/balena-supervisor.git
synced 2025-02-07 20:00:25 +00:00
5197a1330d
A previous PR (#1656) fixed validation for network ipam config, checking that both network and subnet are defined for each ipam config entry (as described in the docker documentation). After that PR, the validations throws an exception if the network target state is incorrect, but this turns out to be the wrong approach, because that exception is also triggered when querying target state. This isn't a problem in normal operation, but it is in local mode, because local mode queries the old target state before sending a new one. Since the query fails, the CLI can never push the new target state. This PR replaces the exception with a warning on the logs, since a misconfigured network won't cause any engine failures, it will just prevent containers to communicate through the provided network. A future improvement should move this validation to an earlier point in the process, so the target state can get rejected before it even gets to a point it can be used. Relates-to: #1693 Change-type: patch