ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-02-23 02:32:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Always back off on image fetch failure

Browse Source 
Change-type: patch
Signed-off-by: Cameron Diver <cameron@balena.io>
This commit is contained in:
Cameron Diver 2019-02-13 15:43:18 +00:00
parent c6d20a598b
commit d9177404b5
No known key found for this signature in database
GPG Key ID: 49690ED87032539F
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/compose/images.ts
View File

@ -136,11 +136,7 @@ export class Images extends (EventEmitter as {
} catch (e) { } catch (e) {
if (!NotFoundError(e)) { if (!NotFoundError(e)) {
if (!(e instanceof ImageDownloadBackoffError)) { if (!(e instanceof ImageDownloadBackoffError)) {
this.imageFetchLastFailureTime[image.name] = process.hrtime(); this.addImageFailure(image.name);
this.imageFetchFailures[image.name] =
this.imageFetchFailures[image.name] != null
? this.imageFetchFailures[image.name] + 1
: 1;
} }
throw e; throw e;
} }
@ -173,6 +169,7 @@ export class Images extends (EventEmitter as {
// processing // processing
this.logger.logSystemEvent(LogTypes.deltaStillProcessingError, {}); this.logger.logSystemEvent(LogTypes.deltaStillProcessingError, {});
} else { } else {
this.addImageFailure(image.name);
this.logger.logSystemEvent(LogTypes.downloadImageError, { this.logger.logSystemEvent(LogTypes.downloadImageError, {
image, image,
error: err, error: err,
@ -232,6 +229,14 @@ export class Images extends (EventEmitter as {
); );
} }
private addImageFailure(imageName: string, time = process.hrtime()) {
this.imageFetchLastFailureTime[imageName] = time;
this.imageFetchFailures[imageName] =
this.imageFetchFailures[imageName] != null
? this.imageFetchFailures[imageName] + 1
: 1;
}
private matchesTagOrDigest( private matchesTagOrDigest(
image: Image, image: Image,
dockerImage: NormalisedDockerImage, dockerImage: NormalisedDockerImage,