ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-02-21 10:01:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use writeAndSync when writing to config.json

Browse Source 
`/mnt/boot` is a vfat partition which does not support atomic file
rename. The best course of action is to write and sync as fast as
possible to prevent corruption (although it still may happen)

Change-type: patch
This commit is contained in:
Felipe Lalanne 2022-01-25 18:34:34 -03:00
parent a0ed00d8f3
commit d071cd1507
1 changed files with 10 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/config/configJson.ts
View File

@ -4,7 +4,7 @@ import { promises as fs } from 'fs';
import * as path from 'path';
import * as constants from '../lib/constants';
import { writeAndSyncFile, writeFileAtomic } from '../lib/fs-utils';
import { writeAndSyncFile } from '../lib/fs-utils';
import * as osRelease from '../lib/os-release';
import log from '../lib/supervisor-console';
@ -86,21 +86,14 @@ export default class ConfigJsonConfigBackend {
});
}
private write(): Promise<void> {
let atomicWritePossible = true;
return this.pathOnHost()
.catch((err) => {
log.error('There was an error detecting the config.json path', err);
atomicWritePossible = false;
return constants.configJsonNonAtomicPath;
})
.then((configPath) => {
if (atomicWritePossible) {
return writeFileAtomic(configPath, JSON.stringify(this.cache));
} else {
return writeAndSyncFile(configPath, JSON.stringify(this.cache));
}
});
private async write(): Promise<void> {
// We use writeAndSyncFile since /mnt/boot partition is a vfat
// filesystem which dows not provide atomic file renames. The best
// course of action on that case is to write and sync as soon as possible
return writeAndSyncFile(
await this.pathOnHost(),
JSON.stringify(this.cache),
);
}
private async read(): Promise<string> {
@ -133,7 +126,7 @@ export default class ConfigJsonConfigBackend {
// then we can't do atomic changes (only access to config.json we have is in /boot,
// which is assumed to be a file bind mount where rename is impossible).
throw new Error(
'Could not determine config.json path on host, atomic write will not be possible',
`OS version '${osVersion}' does not match any known balenaOS version.`,
);
}
}