ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-04-16 23:38:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Ensure poll socket timeout is defined early

Browse Source 
We have observed that even when setting the socket timeout on the
state poll https request, the timeout is only applied once the socket is
connected. This causes issues with Node's auto family selection (happy
eyeballs), as the default https timeout is 5s which means that larger
[auto select attempt timeout](https://nodejs.org/docs/latest-v22.x/api/net.html#netgetdefaultautoselectfamilyattempttimeout) may result in the socket timing out before all connection attempts have been tried.

This commit sets a different https Agent for state polling, with a
timeout matching the `apiRequestTimeout` used for other request events.

Change-type: patch
This commit is contained in:
Felipe Lalanne 2025-03-12 10:31:10 -03:00
parent 978652b292
commit bdbc6a4ba4
No known key found for this signature in database
GPG Key ID: 03E696BFD472B26A
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/api-binder/poll.ts
View File

@ -3,6 +3,7 @@ import url from 'url';
import { setTimeout } from 'timers/promises';
import Bluebird from 'bluebird';
import type StrictEventEmitter from 'strict-event-emitter-types';
import { Agent } from 'https';
import type { TargetState } from '../types/state';
import { InternalInconsistencyError } from '../lib/errors';
@ -120,6 +121,12 @@ export const update = async (
const got = await getGotInstance();
const { statusCode, headers, body } = await got(endpoint, {
agent: {
https: new Agent({
keepAlive: true,
timeout: apiRequestTimeout,
}),
},
headers: {
Authorization: `Bearer ${deviceApiKey}`,
'If-None-Match': cache?.etag,