ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-02-20 17:52:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid querying instantUpdates on every state poll

Browse Source 
Change-type: patch
This commit is contained in:
Pagan Gazzard 2020-05-16 13:08:27 +01:00
parent 29dd8317d8
commit afae5d15d4
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/api-binder.ts
View File

@ -354,7 +354,16 @@ export class APIBinder {
'Trying to start poll without initializing API client',
);
}
this.pollTargetState(true);
this.config
.get('instantUpdates')
.catch(() => {
// Default to skipping the initial update if we couldn't fetch the setting
// which should be the exceptional case
return false;
})
.then((instantUpdates) => {
this.pollTargetState(!instantUpdates);
});
return null;
});
}
@ -602,18 +611,17 @@ export class APIBinder {
});
}
private async pollTargetState(isInitialCall: boolean = false): Promise<void> {
const {
appUpdatePollInterval,
instantUpdates,
} = await this.config.getMany(['appUpdatePollInterval', 'instantUpdates']);
private async pollTargetState(skipFirstGet: boolean = false): Promise<void> {
const appUpdatePollInterval = await this.config.get(
'appUpdatePollInterval',
);
// We add a random jitter up to `maxApiJitterDelay` to
// space out poll requests
let pollInterval =
Math.random() * constants.maxApiJitterDelay + appUpdatePollInterval;
if (instantUpdates || !isInitialCall) {
if (!skipFirstGet) {
try {
await this.getAndSetTargetState(false);
this.targetStateFetchErrors = 0;