ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-06-21 00:23:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve naming of a util function & add unit test

Browse Source 
isOlderThan -> isValidDateAndOlderThan

See: https://github.com/balena-os/balena-supervisor/pull/2170#discussion_r1226809686
Signed-off-by: Christina Ying Wang <christina@balena.io>
This commit is contained in:
Christina Ying Wang
2023-06-14 17:24:30 -07:00
parent ab80f198d8
commit ace642ea0f
3 changed files with 49 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
test/unit/compose/utils.spec.ts
View File

@ -1,8 +1,8 @@
import { expect } from 'chai';
import * as ComposeUtils from '~/src/compose/utils';
describe('compose/utils', () =>
it('Should correctly camel case the configuration', function () {
describe('compose/utils', () => {
it('should correctly camel case the configuration', () => {
const config = {
networks: ['test', 'test2'],
};
@ -10,4 +10,34 @@ describe('compose/utils', () =>
expect(ComposeUtils.camelCaseConfig(config)).to.deep.equal({
networks: ['test', 'test2'],
});
}));
});
it('should return whether a date is valid and older than an interval of seconds', () => {
const now = new Date(Date.now());
expect(ComposeUtils.isValidDateAndOlderThan(now, 60)).to.equal(false);
const time59SecondsAgo = new Date(Date.now() - 59 * 1000);
expect(ComposeUtils.isValidDateAndOlderThan(time59SecondsAgo, 60)).to.equal(
false,
);
const time61SecondsAgo = new Date(Date.now() - 61 * 1000);
expect(ComposeUtils.isValidDateAndOlderThan(time61SecondsAgo, 60)).to.equal(
true,
);
const notDates = [
null,
undefined,
'',
'test',
123,
0,
-1,
Infinity,
NaN,
{},
];
notDates.forEach((n) => {
expect(ComposeUtils.isValidDateAndOlderThan(n, 0)).to.equal(false);
});
});
});