From 9dd1fa24089a45b33e64cc035be30cd120ccea4b Mon Sep 17 00:00:00 2001
From: Pablo Carranza Velez <pablo@resin.io>
Date: Tue, 22 Dec 2015 00:02:59 +0000
Subject: [PATCH] Catch out of sync errors falling back to scratch. Make update
 retries more dependent on number of failures

---
 src/application.coffee  |  2 +-
 src/docker-utils.coffee | 39 ++++++++++++++++++++++++++++-----------
 2 files changed, 29 insertions(+), 12 deletions(-)

diff --git a/src/application.coffee b/src/application.coffee
index 0b18c48f..705bb537 100644
--- a/src/application.coffee
+++ b/src/application.coffee
@@ -586,7 +586,7 @@ application.update = update = (force) ->
 			if updateStatus.state is UPDATE_REQUIRED
 				console.log('Updating failed, but there is already another update scheduled immediately: ', err)
 				return
-			delayTime = Math.min(updateStatus.failed * 500, 30000)
+			delayTime = Math.min((2 ** updateStatus.failed) * 500, 30000)
 			# If there was an error then schedule another attempt briefly in the future.
 			console.log('Scheduling another update attempt due to failure: ', delayTime, err)
 			setTimeout(update, delayTime, force)
diff --git a/src/docker-utils.coffee b/src/docker-utils.coffee
index e73fd88a..c31089a7 100644
--- a/src/docker-utils.coffee
+++ b/src/docker-utils.coffee
@@ -6,9 +6,11 @@ progress = require 'request-progress'
 config = require './config'
 _ = require 'lodash'
 knex = require './db'
-
+TypedError = require 'typed-error'
 { request } = require './request'
 
+class OutOfSyncError extends TypedError
+
 docker = Promise.promisifyAll(new Docker(socketPath: config.dockerSocket))
 # Hack dockerode to promisify internal classes' prototypes
 Promise.promisifyAll(docker.getImage().constructor.prototype)
@@ -39,24 +41,32 @@ findSimilarImage = (repoTag) ->
 		for repoTag in repoTags
 			otherApplication = repoTag[0].split('/')[1]
 			if otherApplication is application
-				return repoTag
+				return repoTag[0]
 
 		# Otherwise return the image for the most specific supervisor tag (commit hash)
 		for repoTag in repoTags when /resin\/.*-supervisor.*:[0-9a-f]{6}/.test(repoTag[0])
-			return repoTag
+			return repoTag[0]
 
 		# Or return *any* supervisor image available (except latest which is usually a phony tag)
 		for repoTag in repoTags when /resin\/.*-supervisor.*:(?!latest)/.test(repoTag[0])
-			return repoTag
+			return repoTag[0]
 
 		# If all else fails, return the newest image available
-		return repoTags[0]
+		for repoTag in repoTags when repoTag[0] isnt '<none>:<none>'
+			return repoTag[0]
 
-exports.rsyncImageWithProgress = (imgDest, onProgress) ->
-	findSimilarImage(imgDest)
-	.spread (imgSrc, imgSrcId) ->
+		return 'resin/scratch'
+
+DELTA_OUT_OF_SYNC_CODES = [23, 24]
+
+exports.rsyncImageWithProgress = (imgDest, onProgress, startFromEmpty = false) ->
+	Promise.try ->
+		if startFromEmpty
+			return 'resin/scratch'
+		findSimilarImage(imgDest)
+	.then (imgSrc) ->
 		rsyncDiff = new Promise (resolve, reject) ->
-			progress request.get("#{config.deltaHost}/api/v1/delta?src=#{imgSrc}&srcId=#{imgSrcId}&dest=#{imgDest}", timeout: 5 * 60 * 1000)
+			progress request.get("#{config.deltaHost}/api/v1/delta?src=#{imgSrc}&dest=#{imgDest}", timeout: 5 * 60 * 1000)
 			.on 'progress', (progress) ->
 				onProgress(percentage: progress.percent)
 			.on 'end', ->
@@ -78,16 +88,23 @@ exports.rsyncImageWithProgress = (imgDest, onProgress) ->
 		return [ rsyncDiff, imageConfig, imgSrc ]
 	.spread (rsyncDiff, imageConfig, imgSrc) ->
 		new Promise (resolve, reject) ->
-			dockersync = spawn('/app/src/dockersync.sh', [ imgSrc, imgDest, JSON.stringify(imageConfig) ], stdio: [ 'pipe', 'ignore', 'ignore' ])
+			dockersync = spawn('/app/src/dockersync.sh', [ imgSrc, imgDest, JSON.stringify(imageConfig) ], stdio: [ 'pipe', 'pipe', 'pipe' ])
 			.on 'error', reject
 			.on 'exit', (code, signal) ->
-				if code isnt 0
+				if code in DELTA_OUT_OF_SYNC_CODES
+					reject(new OutOfSyncError("Incompatible image"))
+				else if code isnt 0
 					reject(new Error("rsync exited. code: #{code} signal: #{signal}"))
 				else
 					resolve()
 
 			rsyncDiff.pipe(dockersync.stdin)
+			dockersync.stdout.pipe(process.stdout)
+			dockersync.stderr.pipe(process.stdout)
 			rsyncDiff.resume()
+	.catch OutOfSyncError, (err) ->
+		console.log('Falling back to delta-from-empty')
+		exports.rsyncImageWithProgress(imgDest, onProgress, true)
 
 do ->
 	# Keep track of the images being fetched, so we don't clean them up whilst fetching.