ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-06-20 00:03:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix references in deploy-to-resin.js and use github credentials when pushing in pr-to-meta-resin.sh

Browse Source 
deploy-to-resin.js had a few references to variables that are no longer defined.

In pr-to-meta-resin.sh, the passing of GitHub credentials was wrongly placed and messy.

As per @Page-'s advice, we use the credentials as part of the remote url when pushing (we don't do it when
cloning to avoid the github password being visible with a `git remote -v`).

We change GITHUB_USERNAME to GITHUB_USER as hub will automatically pick it up, avoiding the need
to pass the credentials when creating the PR.

Change-Type: patch
Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
This commit is contained in:
Pablo Carranza Velez
2017-07-28 00:13:10 -03:00
parent bdf6214d12
commit 925112bd13
2 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
automation/deploy-to-resin.js
View File

@ -68,7 +68,7 @@ resinApi._request(_.extend({
if (_.isEmpty(apiToken)) {
customOptions.apikey = apikey;
}
console.log(`Deploying ${supervisor_version} for ${device_type}`);
console.log(`Deploying ${tag} for ${deviceType.slug}`);
return resinApi.post({
resource: 'supervisor_release',
body: {