Merge pull request #771 from resin-io/tty-true-default

Keep defaulting tty to true to avoid accidental breakage
This commit is contained in:
Pablo Carranza Vélez 2018-10-19 18:01:25 +02:00 committed by GitHub
commit 8a5a6ac519
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -258,7 +258,9 @@ export class Service {
// Sanity check the incoming boolean values
config.oomKillDisable = Boolean(config.oomKillDisable);
config.readOnly = Boolean(config.readOnly);
config.tty = Boolean(config.tty);
if (config.tty != null) {
config.tty = Boolean(config.tty);
}
if (_.isArray(config.sysctls)) {
config.sysctls = _.fromPairs(_.map(config.sysctls, (v) => _.split(v, '=')));
@ -343,7 +345,7 @@ export class Service {
hostname: '',
user: '',
workingDir: '',
tty: false,
tty: true,
});
// Mutate service with extra features