Wrap all update errors as Errors

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Bugfix: wrap all errors from update as Error objects - prevents image cleanup on download failures [Pablo]
 * Wait 10 seconds after sending SIGTERM and before sending SIGKILL when stopping a container [petrosagg]
 
 # v1.0.0

src/application.coffee

@@ -303,6 +303,10 @@ executeSpecialActionsAndBootConfig = (env) ->
 		if !_.isEmpty(bootConfigVars)
 			device.setBootConfig(bootConfigVars)
 
+wrapAsError = (err) ->
+	return err if _.isError(err)
+	return new Error(err.message ? err)
+
 UPDATE_IDLE = 0
 UPDATE_UPDATING = 1
 UPDATE_REQUIRED = 2
@@ -448,7 +452,7 @@ application.update = update = (force) ->
 							.catch (err) ->
 								logSystemEvent(logTypes.updateAppError, app, err)
 								throw err
-					.catch(_.identity)
+					.catch(wrapAsError)
 		.filter(_.isError)
 		.then (failures) ->
 			throw new Error(joinErrorMessages(failures)) if failures.length > 0