This commit is contained in:
Balena CI 2021-05-07 00:20:57 +03:00 committed by VersionBot
parent 07aa3a5001
commit 2f9d52cc6a
5 changed files with 60 additions and 3 deletions

View File

@ -1,3 +1,55 @@
- commits:
- subject: Show warning instead of exception for invalid network config
hash: 5197a1330d69cbff97f3c53a77f640638e074b8a
body: >
A previous PR (#1656) fixed validation for network ipam config,
checking that both network and subnet are defined for each ipam config
entry
(as described in the docker documentation).
After that PR, the validations throws an exception if the network target
state is incorrect,
but this turns out to be the wrong approach, because that exception is
also triggered
when querying target state.
This isn't a problem in normal operation, but it is in local mode,
because local
mode queries the old target state before sending a new one. Since the
query fails,
the CLI can never push the new target state.
This PR replaces the exception with a warning on the logs, since a
misconfigured network won't cause any engine failures, it will just
prevent containers to communicate through the provided network.
A future improvement should move this validation to an earlier point in
the process,
so the target state can get rejected before it even gets to a point it
can be used.
footer:
Relates-to: '#1693'
relates-to: '#1693'
Change-type: patch
change-type: patch
author: Felipe Lalanne
nested: []
version: 12.6.8
date: 2021-05-06T20:30:52.075Z
- commits: - commits:
- subject: Patch awaiting response when checking if supervisor0 network exists - subject: Patch awaiting response when checking if supervisor0 network exists
hash: 8b0c2347d8d04d3c7101016f6c885f31d9b3dc6a hash: 8b0c2347d8d04d3c7101016f6c885f31d9b3dc6a

View File

@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file
automatically by Versionist. DO NOT EDIT THIS FILE MANUALLY! automatically by Versionist. DO NOT EDIT THIS FILE MANUALLY!
This project adheres to [Semantic Versioning](http://semver.org/). This project adheres to [Semantic Versioning](http://semver.org/).
# v12.6.8
## (2021-05-06)
* Show warning instead of exception for invalid network config [Felipe Lalanne]
# v12.6.7 # v12.6.7
## (2021-05-06) ## (2021-05-06)

View File

@ -1 +1 @@
12.6.7 12.6.8

2
package-lock.json generated
View File

@ -1,6 +1,6 @@
{ {
"name": "balena-supervisor", "name": "balena-supervisor",
"version": "12.6.7", "version": "12.6.8",
"lockfileVersion": 1, "lockfileVersion": 1,
"requires": true, "requires": true,
"dependencies": { "dependencies": {

View File

@ -1,7 +1,7 @@
{ {
"name": "balena-supervisor", "name": "balena-supervisor",
"description": "This is balena's Supervisor, a program that runs on IoT devices and has the task of running user Apps (which are Docker containers), and updating them as the balena API informs it to.", "description": "This is balena's Supervisor, a program that runs on IoT devices and has the task of running user Apps (which are Docker containers), and updating them as the balena API informs it to.",
"version": "12.6.7", "version": "12.6.8",
"license": "Apache-2.0", "license": "Apache-2.0",
"repository": { "repository": {
"type": "git", "type": "git",