ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2024-12-20 22:23:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #156 from resin-io/154-restore-private-env-vars

Browse Source 
bugfix: do not mutate original env vars object
This commit is contained in:
Kostas Lekkas 2016-06-01 14:18:27 +03:00
commit 131f7f5b22
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/utils.coffee
View File

@ -36,6 +36,8 @@ exports.mixpanelTrack = (event, properties = {}) ->
message: properties.error.message message: properties.error.message
stack: properties.error.stack stack: properties.error.stack
properties = _.cloneDeep(properties)
# Don't log private env vars (e.g. api keys) # Don't log private env vars (e.g. api keys)
if properties?.app?.env? if properties?.app?.env?
try try
@ -48,7 +50,7 @@ exports.mixpanelTrack = (event, properties = {}) ->
console.log('Event:', event, JSON.stringify(properties)) console.log('Event:', event, JSON.stringify(properties))
# Mutation is bad, and it should feel bad # Mutation is bad, and it should feel bad
properties = _.assign(_.cloneDeep(properties), mixpanelProperties) properties = _.assign(properties, mixpanelProperties)
mixpanelClient.track(event, properties) mixpanelClient.track(event, properties)