ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-05-02 09:02:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2157 from balena-os/api-integration-test-restart-timeout-fix

Browse Source 
Fix assertion error in restart-service
This commit is contained in:
Felipe Lalanne 2023-04-10 10:17:06 -05:00 committed by GitHub
commit 06f764ad77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/integration/device-api/actions.spec.ts
View File

@ -522,9 +522,19 @@ describe('manages application lifecycle', () => {
it('should restart service by removing and recreating corresponding container', async () => { it('should restart service by removing and recreating corresponding container', async () => {
containers = await waitForSetup(targetState); containers = await waitForSetup(targetState);
const isRestartSuccessful = startTimesChanged( const serviceName = serviceNames[0];
containers.map((ctn) => ctn.State.StartedAt), const { State } = containers.filter((ctn) =>
); ctn.Name.startsWith(`/${serviceName}`),
)[0];
const { StartedAt: startedAt } = State;
const isRestartSuccessful = (ctns: Docker.ContainerInspectInfo[]) =>
ctns.some(
(ctn) =>
ctn.Name.startsWith(`/${serviceName}`) &&
ctn.State.StartedAt !== startedAt,
);
// Calling actions.executeServiceAction directly doesn't work // Calling actions.executeServiceAction directly doesn't work
// because it relies on querying target state of the balena-supervisor // because it relies on querying target state of the balena-supervisor
@ -543,10 +553,12 @@ describe('manages application lifecycle', () => {
// containers have been restarted, but verify explcitly with an assertion // containers have been restarted, but verify explcitly with an assertion
expect(isRestartSuccessful(restartedContainers)).to.be.true; expect(isRestartSuccessful(restartedContainers)).to.be.true;
// Containers should have different Ids since they're recreated // One container should have the same Id as before the restart call, since
expect(restartedContainers.map(({ Id }) => Id)).to.not.have.members( // it wasn't restarted.
containers.map((ctn) => ctn.Id), const sharedIds = restartedContainers
); .map(({ Id }) => Id)
.filter((id) => containers.some((ctn) => ctn.Id === id));
expect(sharedIds.length).to.equal(1);
}); });
it('should stop a running service', async () => { it('should stop a running service', async () => {