ExternalVendorCode/balena-supervisor
1
0
Fork 0
mirror of https://github.com/balena-os/balena-supervisor.git synced 2025-04-16 23:38:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Release locks when removing apps

Browse Source 
This prevents leftover locks that can prevent other operations from
taking place.

Change-type: patch
This commit is contained in:
Felipe Lalanne 2025-03-06 11:39:40 -03:00
parent 5ef6b054fd
commit 026dc0aed2
No known key found for this signature in database
GPG Key ID: 03E696BFD472B26A
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/compose/app.ts
View File

@ -247,6 +247,16 @@ class AppImpl implements App {
}
}
// Release locks (if any) for all services before settling state
if (state.lock || state.hasLeftoverLocks) {
return [
generateStep('releaseLock', {
appId: this.appId,
lock: state.lock,
}),
];
}
return [];
}

14
test/unit/compose/app.spec.ts
View File

@ -2399,5 +2399,19 @@ describe('compose/app', () => {
const [releaseLockStep] = expectSteps('releaseLock', steps, 1);
expect(releaseLockStep).to.have.property('appId').that.equals(1);
});
it('should infer a releaseLock step when removing an app', async () => {
const current = createApp({
services: [],
networks: [],
});
const steps = current.stepsToRemoveApp({
...defaultContext,
lock: mockLock,
});
const [releaseLockStep] = expectSteps('releaseLock', steps, 1);
expect(releaseLockStep).to.have.property('appId').that.equals(1);
});
});
});