ExternalVendorCode/balena-cli
1
0
Fork 0
mirror of https://github.com/balena-io/balena-cli.git synced 2025-01-29 15:44:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

improve input validation for key, key rm

Browse Source 
Change-type: patch
Resolves: #1728
Signed-off-by: Scott Lowe <scott@balena.io>
This commit is contained in:
Scott Lowe 2020-04-15 17:00:51 +02:00
parent eba2e7e4fb
commit cff9e50a22
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/actions/keys.ts
View File

@ -1,5 +1,5 @@
/*
Copyright 2016-2017 Balena
Copyright 2016-2020 Balena Ltd.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
@ -15,9 +15,17 @@ limitations under the License.
*/
import { CommandDefinition } from 'capitano';
import { ExpectedError } from '../errors';
import { getBalenaSdk, getVisuals } from '../utils/lazy';
import * as commandOptions from './command-options';
function parseId(id: string): number {
if (/^[\d]+$/.exec(id) == null) {
throw new ExpectedError('The key id must be an integer');
}
return Number(id);
}
export const list: CommandDefinition = {
signature: 'keys',
description: 'list all ssh keys',
@ -48,7 +56,7 @@ Examples:
`,
permission: 'user',
async action(params) {
const key = await getBalenaSdk().models.key.get(parseInt(params.id, 10));
const key = await getBalenaSdk().models.key.get(parseId(params.id));
console.log(getVisuals().table.vertical(key, ['id', 'title']));
@ -86,7 +94,7 @@ Examples:
'Are you sure you want to delete the key?',
);
await getBalenaSdk().models.key.remove(parseInt(params.id, 10));
await getBalenaSdk().models.key.remove(parseId(params.id));
},
};