From 9bb04f43a84c5fb5e848a8ad0f6e0fe2356da229 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Mon, 11 May 2015 14:23:34 -0300 Subject: [PATCH] Fix callback not being called on success in os download command --- build/actions/os.js | 4 +--- lib/actions/os.coffee | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/build/actions/os.js b/build/actions/os.js index fc5dea36..59e9563f 100644 --- a/build/actions/os.js +++ b/build/actions/os.js @@ -74,9 +74,7 @@ spinner = new visuals.widgets.Spinner('Downloading Device OS (size unknown)'); return resin.models.os.download(osParams, options.output, function(error) { spinner.stop(); - if (error != null) { - return callback(error); - } + return callback(error); }, function(state) { if (state != null) { return bar.update(state); diff --git a/lib/actions/os.coffee b/lib/actions/os.coffee index f7eac9f8..9bcdb2fc 100644 --- a/lib/actions/os.coffee +++ b/lib/actions/os.coffee @@ -82,7 +82,7 @@ exports.download = resin.models.os.download osParams, options.output, (error) -> spinner.stop() - return callback(error) if error? + return callback(error) , (state) -> if state? bar.update(state)