From 30663b0301f927d6bc3ef733534a828f431ed33b Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Tue, 8 Mar 2016 09:20:22 -0400 Subject: [PATCH] Force update alert to be always shown If `updateCheckInterval` has any meanginful value, the alert will be shown one out of ten times, or something like that, making the user likely to miss updates. The underlying issue is that `update-notifier`, if it detects a cached update notification, it deletes it, and only attempts to show it back if `updateCheckInterval` is greater than `Date.now() - lastUpdateCheck`. --- build/utils/update.js | 3 ++- lib/utils/update.coffee | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/build/utils/update.js b/build/utils/update.js index 2f4266d2..1ecc7619 100644 --- a/build/utils/update.js +++ b/build/utils/update.js @@ -26,7 +26,8 @@ limitations under the License. if (!isRoot()) { notifier = updateNotifier({ - pkg: packageJSON + pkg: packageJSON, + updateCheckInterval: 0 }); } diff --git a/lib/utils/update.coffee b/lib/utils/update.coffee index 16d291da..310f0437 100644 --- a/lib/utils/update.coffee +++ b/lib/utils/update.coffee @@ -22,7 +22,13 @@ packageJSON = require('../../package.json') # running time ask for updated, however this can lead # to ugly EPERM issues if those files are created as root. if not isRoot() - notifier = updateNotifier(pkg: packageJSON) + notifier = updateNotifier + pkg: packageJSON + + # Force update notification alert + # to be shown every time there is + # an update. + updateCheckInterval: 0 exports.hasAvailableUpdate = -> return notifier?