Refactor npm related logic to plugins

lib/actions/plugin.coffee

@@ -1,9 +1,7 @@
 _ = require('lodash')
-_.str = require('underscore.string')
-async = require('async')
-npm = require('npm')
 visuals = require('resin-cli-visuals')
 commandOptions = require('./command-options')
+plugins = require('../plugins')
 
 exports.list =
 	signature: 'plugins'
@@ -16,37 +14,21 @@ exports.list =
 	'''
 	permission: 'user'
 	action: (params, options, done) ->
-		async.waterfall([
+		plugins.list 'resin-plugin', (error, resinPlugins) ->
+			return done(error) if error?
 
-			(callback) ->
-				npm.load
-					depth: 0
-					parseable: true
-				, callback
+			if _.isEmpty(resinPlugins)
+				console.log('You don\'t have any plugins yet')
+				return done()
 
-			(data, callback) ->
-				npm.commands.list([], true, callback)
+			console.log visuals.widgets.table.horizontal resinPlugins, [
+				'name'
+				'version'
+				'description'
+				'license'
+			]
 
-			(data, lite, callback) ->
-				resinModules = _.filter _.values(data.dependencies), (resinModule) ->
-
-					# TODO: Reuse plugin glob from app.coffee
-					return _.str.startsWith(resinModule.name, 'resin-plugin')
-
-				if _.isEmpty(resinModules)
-					console.log('You don\'t have any plugins yet')
-					return done()
-
-				console.log visuals.widgets.table.horizontal resinModules, [
-					'name'
-					'version'
-					'description'
-					'license'
-				]
-
-				return callback()
-
-		], done)
+			return done()
 
 exports.install =
 	signature: 'plugin install <name>'
@@ -59,34 +41,14 @@ exports.install =
 	'''
 	permission: 'user'
 	action: (params, options, done) ->
-		async.waterfall [
-
-			(callback) ->
-				npm.load({}, callback)
-
-			(data, callback) ->
-
-				# TODO: This action outputs installation information that cannot
-				# be quieted neither with --quiet nor --silent:
-				# https://github.com/npm/npm/issues/2040
-				npm.commands.install([
-					"resin-plugin-#{params.name}"
-				], callback)
-
-			(installedModules, modules, lite, callback) ->
-				for installedModule in installedModules
-					console.info("Plugin installed: #{_.first(installedModule)}")
-
-				return callback()
-
-		], (error) ->
-			return done() if not error?
-
-			if error.code is 'E404'
-				error.message = "Plugin not found: #{params.name}"
-
+		plugins.install "resin-plugin-#{params.name}", (error, installedModules) ->
 			return done(error) if error?
 
+			for installedModule in installedModules
+				console.info("Plugin installed: #{installedModule}")
+
+			return done()
+
 exports.remove =
 	signature: 'plugin rm <name>'
 	description: 'remove a plugin'
@@ -103,22 +65,11 @@ exports.remove =
 	options: [ commandOptions.yes ]
 	permission: 'user'
 	action: (params, options, done) ->
-		async.waterfall([
+		visuals.patterns.remove 'plugin', options.yes, (callback) ->
+			plugins.remove("resin-plugin-#{params.name}", callback)
+		, (error, uninstalledPlugin) ->
+			return done(error) if error?
 
-			(callback) ->
-				npm.load(loglevel: 'silent', callback)
+			console.info("Plugin removed: #{uninstalledPlugin}")
 
-			(data, callback) ->
-				visuals.patterns.remove 'plugin', options.yes, (callback) ->
-					npm.commands.uninstall([
-						"resin-plugin-#{params.name}"
-					], callback)
-				, callback
-
-			(uninstalledPlugins, callback) ->
-				if _.isEmpty(uninstalledPlugins)
-					return callback(new Error("Plugin not found: #{params.name}"))
-				console.info("Plugin removed: #{params.name}")
-				return callback()
-
-		], done)
+			return done()

lib/plugins.coffee

@@ -1,5 +1,8 @@
+async = require('async')
+npm = require('npm')
 nplugm = require('nplugm')
 _ = require('lodash')
+_.str = require('underscore.string')
 capitano = require('capitano')
 
 registerPlugin = (plugin) ->
@@ -11,3 +14,66 @@ exports.register = (glob, callback) ->
 		return console.error(error.message) if error?
 		registerPlugin(plugin.require())
 	, callback
+
+exports.install = (name, callback) ->
+	async.waterfall [
+
+		(callback) ->
+			npm.load({}, callback)
+
+		(data, callback) ->
+
+			# TODO: This action outputs installation information that cannot
+			# be quieted neither with --quiet nor --silent:
+			# https://github.com/npm/npm/issues/2040
+			npm.commands.install([ name ], callback)
+
+		(installedModules, modules, lite, callback) ->
+			installedModules = _.map(installedModules, _.first)
+			return callback(null, installedModules)
+
+	], (error, installedModules) ->
+		return callback(null, installedModules) if not error?
+
+		if error.code is 'E404'
+			error.message = "Plugin not found: #{params.name}"
+
+		return callback(error) if error?
+
+exports.remove = (name, callback) ->
+	async.waterfall([
+
+		(callback) ->
+			npm.load(loglevel: 'silent', callback)
+
+		(data, callback) ->
+			npm.commands.uninstall([ name ], callback)
+
+		(uninstalledPlugins, callback) ->
+			if _.isEmpty(uninstalledPlugins)
+				return callback(new Error("Plugin not found: #{name}"))
+			return callback(null, _.first(uninstalledPlugins))
+
+	], callback)
+
+exports.list = (prefix, callback) ->
+	async.waterfall([
+
+		(callback) ->
+			npm.load
+				depth: 0
+				parseable: true
+			, callback
+
+		(data, callback) ->
+			npm.commands.list([], true, callback)
+
+		(data, lite, callback) ->
+			plugins = _.filter _.values(data.dependencies), (plugin) ->
+
+				# TODO: Use node-glob
+				return _.str.startsWith(plugin.name, prefix)
+
+			return callback(null, plugins)
+
+	], callback)