ExternalVendorCode/balena-cli
1
0
Fork 0
mirror of https://github.com/balena-io/balena-cli.git synced 2025-02-21 17:56:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Address review feedback

Browse Source
This commit is contained in:
Akis Kesoglou 2018-03-20 14:05:14 +02:00
parent 9455d438e2
commit 4f167cb836
2 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/actions/deploy.coffee
View File

@ -91,11 +91,7 @@ deployProject = (docker, logger, composeOpts, opts) ->
legacyDeploy legacyDeploy
) )
.then (releaseId) -> .then (releaseId) ->
sdk.pine.get sdk.models.release.get(releaseId, $select: [ 'commit' ])
resource: 'release'
id: releaseId
options:
$select: [ 'commit' ]
Promise.join( Promise.join(
sdk.auth.getUserId() sdk.auth.getUserId()
sdk.auth.getToken() sdk.auth.getToken()

19
lib/utils/deploy-legacy.coffee
View File

@ -28,12 +28,6 @@ showPushProgress = (message) ->
progressBar.update({ percentage: 0 }) progressBar.update({ percentage: 0 })
return progressBar return progressBar
forwardStatusMessageFromRemote = (logger, msg) ->
msg.split(/\r\n|\n/).forEach (line) ->
if /^Warning: This endpoint is deprecated/.test(line)
return
logger.logInfo(line)
uploadToPromise = (uploadRequest, logger) -> uploadToPromise = (uploadRequest, logger) ->
new Promise (resolve, reject) -> new Promise (resolve, reject) ->
@ -48,14 +42,11 @@ uploadToPromise = (uploadRequest, logger) ->
reject(e) reject(e)
return return
if obj.type? switch obj.type
switch obj.type when 'error' then reject(new Error("Remote error: #{obj.error}"))
when 'error' then reject(new Error("Remote error: #{obj.error}")) when 'success' then resolve(obj)
when 'success' then resolve(obj) when 'status' then logger.logInfo(obj.message)
when 'status' then forwardStatusMessageFromRemote(logger, obj.message) else reject(new Error("Received unexpected reply from remote: #{data}"))
else reject(new Error("Received unexpected reply from remote: #{data}"))
else
reject(new Error("Received unexpected reply from remote: #{data}"))
uploadRequest uploadRequest
.on('error', reject) .on('error', reject)