Address review feedback

This commit is contained in:
Akis Kesoglou 2018-03-20 14:05:14 +02:00
parent 9455d438e2
commit 4f167cb836
2 changed files with 6 additions and 19 deletions

View File

@ -91,11 +91,7 @@ deployProject = (docker, logger, composeOpts, opts) ->
legacyDeploy
)
.then (releaseId) ->
sdk.pine.get
resource: 'release'
id: releaseId
options:
$select: [ 'commit' ]
sdk.models.release.get(releaseId, $select: [ 'commit' ])
Promise.join(
sdk.auth.getUserId()
sdk.auth.getToken()

View File

@ -28,12 +28,6 @@ showPushProgress = (message) ->
progressBar.update({ percentage: 0 })
return progressBar
forwardStatusMessageFromRemote = (logger, msg) ->
msg.split(/\r\n|\n/).forEach (line) ->
if /^Warning: This endpoint is deprecated/.test(line)
return
logger.logInfo(line)
uploadToPromise = (uploadRequest, logger) ->
new Promise (resolve, reject) ->
@ -48,14 +42,11 @@ uploadToPromise = (uploadRequest, logger) ->
reject(e)
return
if obj.type?
switch obj.type
when 'error' then reject(new Error("Remote error: #{obj.error}"))
when 'success' then resolve(obj)
when 'status' then forwardStatusMessageFromRemote(logger, obj.message)
else reject(new Error("Received unexpected reply from remote: #{data}"))
else
reject(new Error("Received unexpected reply from remote: #{data}"))
switch obj.type
when 'error' then reject(new Error("Remote error: #{obj.error}"))
when 'success' then resolve(obj)
when 'status' then logger.logInfo(obj.message)
else reject(new Error("Received unexpected reply from remote: #{data}"))
uploadRequest
.on('error', reject)