ExternalVendorCode/balena-cli
1
0
Fork 0
mirror of https://github.com/balena-io/balena-cli.git synced 2024-12-18 21:27:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove Buffer polyfill, require Node v6+, and print warnings in older versions

Browse Source
This commit is contained in:
Tim Perry 2017-06-22 18:58:09 +02:00
parent 11079caf26
commit 410390a9ae
4 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -3,6 +3,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).
## Fixed
- **Breaking** Remove Buffer polyfill, require Node v6+, and print warnings in older versions
## [5.11.1] - 2017-06-22
## Added

8
build/app.js
View File

@ -15,7 +15,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
var Promise, Raven, _, actions, capitano, capitanoExecuteAsync, errors, events, globalTunnel, plugins, proxy, resin, settings, update;
var Promise, Raven, _, actions, capitano, capitanoExecuteAsync, errors, events, globalTunnel, plugins, proxy, resin, settings, update, validNodeVersions;
Raven = require('raven');
@ -36,7 +36,11 @@ Raven.setContext({
}
});
require('buffer-v6-polyfill');
validNodeVersions = require('../package.json').engines.node;
if (!require('semver').satisfies(process.version, validNodeVersions)) {
console.warn("Warning: this version of Node does not match the requirements of this package. This package expects " + validNodeVersions + ", but you're using " + process.version + ". This may cause unexpected behaviour.");
}
globalTunnel = require('global-tunnel-ng');

7
lib/app.coffee
View File

@ -27,7 +27,12 @@ Raven.setContext
args: process.argv
node_version: process.version
require('buffer-v6-polyfill')
validNodeVersions = require('../package.json').engines.node
if not require('semver').satisfies(process.version, validNodeVersions)
console.warn("Warning: this version of Node does not match the requirements of this package.
This package expects #{validNodeVersions}, but you're using #{process.version}.
This may cause unexpected behaviour.")
# Doing this before requiring any other modules,
# including the 'resin-sdk', to prevent any module from reading the http proxy config

5
package.json
View File

@ -25,6 +25,9 @@
],
"author": "Juan Cruz Viotti <juan@resin.io>",
"license": "Apache-2.0",
"engines": {
"node": ">=6.0"
},
"devDependencies": {
"ent": "^2.2.0",
"gulp": "^3.9.0",
@ -40,7 +43,6 @@
"babel-register": "^6.16.3",
"bash": "0.0.1",
"bluebird": "^3.3.3",
"buffer-v6-polyfill": "^1.0.3",
"capitano": "^1.7.0",
"chalk": "^1.1.3",
"coffee-script": "^1.12.6",
@ -86,6 +88,7 @@
"resin-sync": "^7.0.0",
"rimraf": "^2.4.3",
"rindle": "^1.0.0",
"semver": "^5.3.0",
"stream-to-promise": "^2.2.0",
"tmp": "0.0.31",
"umount": "^1.1.6",